tool_operate: more defensive socket code #14304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- use 'struct sockaddr' to getsockname() and its sa_family member - use 'curl_socklen_t' instead of 'socklen_t' - check for AF_INET6 to exist instead assuming it does Reported-by: Harry Sintonen
|
I'm guessing the removal of the __TANDEM fix was an accident.
|
Actually not. This uses |
|
@rsbeckerca can you check if this version builds fine for you on NonStop? It seems like a generally more portable approach. |
Yes. $DAYJOB is kicking my ____ I will get to this shortly. |
|
I'll go ahead and merge this in the mean time as this helps other platforms and I suspect it works on NonStop as well. |
|
Build on NonStop works. Starting test suite. |
|
@bagder LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use 'struct sockaddr' to getsockname() and its sa_family member
use 'curl_socklen_t' instead of 'socklen_t'
check for AF_INET6 to exist instead assuming it does
Reported-by: Harry Sintonen