Thanks.
Maybe for symmetry of the callout you could add something here, too:
```
// (Not neccessary to trim trailing newline from data.)
for line := range Lines(data) {
```
Or maybe it's fine no…
Thanks.
I like CL 610565 too, it's the same general approach as CL 611657 but provides more of an explanation, and it's ready to go without needing rebasing. Thanks for sending it, let's go with it.
(1 comment)
That first comparison is inverted, it should've been:
```suggestion
if version.Compare(ver, version.Lang(minBootstrap)) == 1 && version.Compare(ver, minBootstrap) == -1 {
```
To be cl…
My suggestions are similar to Ian's (I started typing them before seeing Ian's comment, but posting after).
tryDirs[1] below isn't very readable. Let's maybe replace this with:
```
const minBootstr…
(1 comment)
@[email protected] As another minor point, there's a difference in behavior between the two implementations. It has to do with how bytes.Split(data, []byte{'\n'}) will behave when there is…
I too considered `testing.Testing` and would’ve liked to use it previously [here](https://go-review.googlesource.com/c/go/+/503675/comment/dfba4b3e_f392ce7d/), but testing is too big of a dependenc…
Resources were cleaned up after migrating some of those legacy builders to LUCI, so not all of the legacy builders will work by now.
The legacy slowbot request has been running for 55 hrs and produc…
I think the latest FreeBSD builder right now is on 13.1. I asked the FreeBSD port maintainers for input on this in https://go.dev/issue/61095#issuecomment-2334940821.
Based on https://www.freebsd.org/releases/, FreeBSD 13.0 is EOL, and its most recent releases are 13.3, 14.0, and 14.1.
CC @mengzhuo Is it right that https://ci.chromium.org/ui/p/golang/builders/l…
One of the nested modules in x/example can't be tested on the Go 1.22 release branch, not without upgrading to a Go 1.23 toolchain, as reported by its LUCI builders here (added recently in [CL 608495…
Thanks, submitting this as is then to drop the [broken](https://logs.chromium.org/logs/golang/buildbucket/cr-buildbucket/8737517895624089569/+/u/step/17/log/3) 1.19/1.20 post-submit builders. Please …
A sketch of how this can be implemented:
- add an input property to [`golangbuild`](https://cs.opensource.google/go/x/build/+/master:cmd/golangbuild/README.md), something like `upgrade_go_directiv…
Ok, thanks.
It's possible to split this into deleting post-submit builders only for now. That way the optional pre-submit builders can perhaps stay around longer, in case they end up helpful for gop…
Thanks for filing an issue.
Since this is about deciding a long-term strategy, I think it's important to consider #56986 here. That work was implemented fairly recently in Go 1.21 and its effect m…
Thank you Dragan for for your work on maintaining the builders, and sending this update.
See the inline comment - after that's resolved we can submit this.
As is, this new code will panic (see [her…
Nice work on making this kind of a test, thanks.
The E2E Go release tests are in another package (partly so it's easier to for them to avoid accidentally depending on internals of task, partly to le…
This change makes sure that we are properly checking the ignored field
recursion depth in decIgnoreOpFor consistently. This prevents stack
exhaustion when attempting to decode a message that contains…
Thanks, the builder is back and passing again.
@millerresearch, @0intro Have you had a chance to see [CL 608155](https://go.dev/cl/608155)? Shall we proceed with it now? Thanks.
LUCI build https://ci.chromium.org/b/8737704283378549569 uncovers a potential panic in a golangbuild dependency during cleanup:
```
[...]
[I2024-09-04T18:03:18.887542Z 266889 0 butler.go:395] ad…
There's some similarity here to the situation in CL 610676. The calls
that now look like g.Printf("%s", something) would perhaps be better
expressed like g.Print(something) or g.WriteString(something…
The CodeWriter.WriteComment method is odd. It calls fmt.Sprintf
on its arguments so the caller doesn't need to, but isn't named
something like WriteCommentf as I'd expect. I tried renaming it,
but it…
List of golang.org/x repos that need attention:
- [x] x/build (resolved in [CL 610816](https://go.dev/cl/610816))
- [x] x/crypto (resolved in [CL 610797](https://go.dev/cl/610797))
- x/benchmark…
Thanks for working on this Paul. From what I can tell this case (`cas` failing to build for aix/ppc64) is the only known outstanding issue for this port. It's a good idea to check ahead for possible …
Do you think this is this similar or related to issue #68976? (It wasn't listed in the comment above, but it feels similar from a very quick look.)
CC @prattmic, @matloob.
Thanks for reporting this. From a quick look, this might actually be a bug that affects only the "auto" mode. I can reproduce your screenshot when the theme toggle is set to "auto":
<img width="36…
This backport issue has been in WaitingForInfo state because it's not actionable until the upstream issue has a resolution. Closing for now, it's easy enough to re-open or create new backport issues …
This backport issue has been in WaitingForInfo state because it's not actionable until the upstream issue has a resolution. Closing for now, it's easy enough to re-open or create new backport issues …
Thanks. While go1.22.0 is a good starting point (upgraded recently in CL 610435 from its previous value of 1.9), as discussed offline, you can still manually pick a newer 1.22 minor release if there'…
Thanks.
The other two deploy files (including for tip playground) use `latestgo -prev` for the bootstrap, as the commit message says. This one leaves `-prev` out, which seems unintentional.
That sa…
(1 comment)
Fortunately this case was just a matter of me reading "default GODEBUG ..." and leaving a quick comment to pause Auto-Submit and check it's still true after the 1.19 -> newer go version …
Add a wasm build constraint to a WebAssembly-specific command.
Encountering an empty go.mod file can be confusing for humans
and for builders. Remove it, it's probably not needed anymore.
Thanks.
This was previously looping over e.cachedVals and deleting from e.cache, while the new code always clears e.cache. It might very well be equivalent and simpler code if e.cachedVals is guaran…
We still want to be able to trigger them in the very immediate future,
but they no don't need to be included by default and block submission.
For golang/go#65917.