Activity
Today
dmitshur reviewed +2 on golang.org/x/website/_content/blog/range-functions: trim tailing newline in bytes.Split example10h
Thanks.
Maybe for symmetry of the callout you could add something here, too:
```
// (Not neccessary to trim trailing newline from data.)
for line := range Lines(data) {
```
Or maybe it's fine no…dmitshur commented on golang.org/x/website/_content/blog: fix example code in range-functions post10h
Thanks.
I like CL 610565 too, it's the same general approach as CL 611657 but provides more of an explanation, and it's ready to go without needing rebasing. Thanks for sending it, let's go with it.dmitshur reopened a change golang.org/x/website/_content/blog/range-functions: trim tailing newline in bytes.Split example10h
dmitshur commented on cmd/dist: enforce the lowest bootstrap version20h
(1 comment)
That first comparison is inverted, it should've been:
```suggestion
if version.Compare(ver, version.Lang(minBootstrap)) == 1 && version.Compare(ver, minBootstrap) == -1 {
```
To be cl…dmitshur commented on cmd/dist: enforce the lowest bootstrap version21h
My suggestions are similar to Ian's (I started typing them before seeing Ian's comment, but posting after).
tryDirs[1] below isn't very readable. Let's maybe replace this with:
```
const minBootstr…Yesterday
dmitshur commented on golang.org/x/website/_content/blog: fix example code in range-functions post1d
(1 comment)
@[email protected] As another minor point, there's a difference in behavior between the two implementations. It has to do with how bytes.Split(data, []byte{'\n'}) will behave when there is…dmitshur opened a change golang.org/x/website/_content/blog: fix example code in range-functions post1d
Lines returns a iter.Seq, not iter.Seq2,
so there's only one value to range over.dmitshur commented on net/http: only disable fetch in test1d
I too considered `testing.Testing` and would’ve liked to use it previously [here](https://go-review.googlesource.com/c/go/+/503675/comment/dfba4b3e_f392ce7d/), but testing is too big of a dependenc…dmitshur commented on syscall: follow convention for generated code comment1d
The openbsd-386-72 failure is pre-existing and unrelated to this change; it's tracked in #55261.dmitshur commented on syscall: follow convention for generated code comment1d
Resources were cleaned up after migrating some of those legacy builders to LUCI, so not all of the legacy builders will work by now.
The legacy slowbot request has been running for 55 hrs and produc…Last Week
dmitshur commented on golang/go: changed FreeBSD Version from 12.3 to 13.32d
I think the latest FreeBSD builder right now is on 13.1. I asked the FreeBSD port maintainers for input on this in https://go.dev/issue/61095#issuecomment-2334940821.dmitshur commented on golang.org/x/build/env: host-freebsd-amd64-13_0 (VM Image: freebsd-amd64-130-stable-20211230)2d
Based on https://www.freebsd.org/releases/, FreeBSD 13.0 is EOL, and its most recent releases are 13.3, 14.0, and 14.1.
CC @mengzhuo Is it right that https://ci.chromium.org/ui/p/golang/builders/l…dmitshur commented on golang.org/x/build: add LUCI freebsd-arm64 builder2d
CC @golang/freebsd.dmitshur commented on golang.org/x/build: add LUCI freebsd-arm builder2d
CC @golang/freebsd.dmitshur opened an issue golang.org/x/example/ragserver/ragserver: requires go1.23.0, so go1.22 builders are redundant with go1.23 builders2d
One of the nested modules in x/example can't be tested on the Go 1.22 release branch, not without upgrading to a Go 1.23 toolchain, as reported by its LUCI builders here (added recently in [CL 608495…dmitshur reviewed +2 on golang.org/x/tools/go/callgraph/rta: skip test on js platform2d
Thanks.dmitshur commented on golang.org/x/build/main.star: drop 1.19 and 1.20 from TOOLS_GO_BRANCHES2d
Thanks, submitting this as is then to drop the [broken](https://logs.chromium.org/logs/golang/buildbucket/cr-buildbucket/8737517895624089569/+/u/step/17/log/3) 1.19/1.20 post-submit builders. Please …dmitshur commented on golang.org/x/net/http2/hpack: "id (106) <= evictCount (117)" panic in headerFieldTable.idToIndex2d
CC @neild, @tombergan.dmitshur opened a change golang.org/x/build/influx: update Dockerfile to build with Go 1.232d
dmitshur commented on golang.org/x/build: catch problems in x/ repos gated by module go directive version sooner2d
A sketch of how this can be implemented:
- add an input property to [`golangbuild`](https://cs.opensource.google/go/x/build/+/master:cmd/golangbuild/README.md), something like `upgrade_go_directiv…dmitshur commented on golang.org/x/build/main.star: drop 1.19 and 1.20 from TOOLS_GO_BRANCHES2d
Ok, thanks.
It's possible to split this into deleting post-submit builders only for now. That way the optional pre-submit builders can perhaps stay around longer, in case they end up helpful for gop…dmitshur commented on golang.org/x/tools/gopls: decide on a long-term testing strategy for integration with older Go commands (and GOPACKAGESDRIVERs?)2d
Thanks for filing an issue.
Since this is about deciding a long-term strategy, I think it's important to consider #56986 here. That work was implemented fairly recently in Go 1.21 and its effect m…dmitshur commented on golang.org/x/build/main.star: clean up after dropping release-branch.go1.212d
Yeah, sorry, you got added here when I was mailing the CL stack. I'll add another reviewer later on.dmitshur reviewed +1 on golang.org/x/build/internal/task: rename version input param and add E2E for release flow2d
(1 comment)
Thanks. I wonder, does this test really use internet? I thought all of the fakes were local/offline.dmitshur opened an issue build: adopt Go 1.24 as bootstrap toolchain for Go 1.262d
This is the tracking issue for the Go 1.26 iteration of proposal #54265.dmitshur commented on os: [release-branch.go1.23] dup pidfd if caller sets PidFD manually2d
net/http.TestOmitHTTP2 [passed](https://ci.chromium.org/ui/p/golang/builders/try/go1.23-windows-amd64-longtest/b8737534453641117537/test-results?q=ExactID%3Anet%2Fhttp.TestOmitHTTP2+VHash%3Ad1f1ba6c4…dmitshur reviewed +2 on golang.org/x/example/...: fix some typos2d
Thanks.dmitshur opened a change os: [release-branch.go1.23] dup pidfd if caller sets PidFD manually2d
For #68984.
Fixes #69119.dmitshur reviewed +2 on golang.org/x/build/dashboard: update the owner of rt-rk mips builders2d
Thank you again.dmitshur opened a change golang.org/x/sys/windows/svc: fix printf(var) mistake detected by latest printf checker2d
For golang/go#69267.dmitshur commented on syscall: TestAmbientCapsUserns failures [consistent failure]2d
CC @golang/riscv64.dmitshur reviewed +2 on golang.org/x/build/main.star: enable aliastypeparams builders on presubmit and postsubmit3d
Thanks.dmitshur commented on golang.org/x/build/dashboard: update the owner of rt-rk mips builders3d
Thank you Dragan for for your work on maintaining the builders, and sending this update.
See the inline comment - after that's resolved we can submit this.
As is, this new code will panic (see [her…dmitshur reviewed +1 on golang.org/x/build/internal/task: rename version input param and add E2E for release flow3d
Nice work on making this kind of a test, thanks.
The E2E Go release tests are in another package (partly so it's easier to for them to avoid accidentally depending on internals of task, partly to le…dmitshur commented on golang.org/x/tools/gopls/go.mod: update the go directive to 1.23.13d
Congrats! 🎊dmitshur commented on cmd/cgo: alignment issue with int128 inside of a struct [1.23 backport]3d
@ianlancetaylor This backport is approved, please send backport CLs when you have a chance. Thanks.dmitshur commented on runtime/pprof: block and mutex profile stacks sometimes have "gowrap" root frames3d
CC @golang/runtime.dmitshur commented on os/exec: resource leak on exec failure3d
CC @bradfitz, @ianlancetaylor.dmitshur commented on cmd/go: disabling telemetry causes telemetry files to be written3d
CC @matloob, @samthanawalla, @findleyr.dmitshur closed an issue security: fix CVE-2024-34157 [1.22 backport]3d
dmitshur closed an issue security: fix CVE-2024-34157 [1.23 backport]3d
dmitshur opened a change go/parser: track depth in nested element lists3d
Prevents stack exhaustion with extremely deeply nested literal values,
i.e. field values in structs.
Fixes #69138
Fixes CVE-2024-34155dmitshur opened a change golang.org/x/website/internal/history: document Go 1.23.1 and 1.22.7 releases3d
dmitshur opened a change go/parser: [release-branch.go1.22] track depth in nested element lists3d
Prevents stack exhaustion with extremely deeply nested literal values,
i.e. field values in structs.
Updates #69138
Fixes #69142
Fixes CVE-2024-34155dmitshur opened a change encoding/gob: [release-branch.go1.23] cover missed cases when checking ignore depth3d
This change makes sure that we are properly checking the ignored field
recursion depth in decIgnoreOpFor consistently. This prevents stack
exhaustion when attempting to decode a message that contains…dmitshur fixed an issue all: fix printf(var) mistakes newly found in golang.org/x repos3d
I believe all are updated. Please comment or re-open if some repo was missed.
Thanks @adonovan, @timothy-king, @ianlancetaylor.dmitshur commented on golang.org/x/website/_content/css: color of buttons and links, in auto (dark) theme3d
Thanks. Replacing myself with Hana as a reviewer (as x/website owner per https://dev.golang.org/owners); please update that further as needed.dmitshur closed an issue golang.org/x/build/dashboard: unrecognized failures3d
Duplicate of #69271dmitshur closed an issue golang.org/x/build/internal/cloud: unrecognized failures4d
Duplicate of https://github.com/golang/go/issues/69271dmitshur commented on golang.org/x/build: add LUCI plan9-arm builder4d
Thanks, the builder is back and passing again.
@millerresearch, @0intro Have you had a chance to see [CL 608155](https://go.dev/cl/608155)? Shall we proceed with it now? Thanks.dmitshur closed an issue build: build failure on x_tools-go1.22-linux-ppc64le_power104d
This might not be platform-specific (or it might be). Filed a more narrow issue #69276.dmitshur opened an issue golang.org/x/build/cmd/golangbuild: potential send on closed channel during cleanup4d
LUCI build https://ci.chromium.org/b/8737704283378549569 uncovers a potential panic in a golangbuild dependency during cleanup:
```
[...]
[I2024-09-04T18:03:18.887542Z 266889 0 butler.go:395] ad…dmitshur fixed an issue golang.org/x/exp/rand: unrecognized failures4d
Fixed in [CL 610935](https://go.dev/cl/610935).dmitshur fixed an issue golang.org/x/crypto/acme/autocert/internal/acmetest: unrecognized failures4d
Fixed in [CL 610797](https://go.dev/cl/610797).dmitshur closed an issue golang.org/x/build/internal/buildgo: unrecognized failures4d
Duplicate of #69271dmitshur fixed an issue golang.org/x/build/dashboard: unrecognized failures4d
Fixed in [CL 610816](https://go.dev/cl/610816).dmitshur fixed an issue golang.org/x/net/websocket: unrecognized failures4d
Fixed in [CL 610799](https://go.dev/cl/610799).dmitshur reviewed +2 on golang.org/x/website/doc/articles/race_detector: update for Go 1.22 loop variable changes4d
Thanks.dmitshur commented on golang.org/x/mobile/...: fix printf(var) mistakes detected by latest printf checker4d
Thanks.dmitshur commented on golang.org/x/benchmarks/...: fix printf(var) mistakes detected by latest printf checker4d
TestSweetEndToEnd has a history of failing every now and then. It passed on the second try. Bypassing.dmitshur opened a change golang.org/x/mobile/...: fix printf(var) mistakes detected by latest printf checker4d
There's some similarity here to the situation in CL 610676. The calls
that now look like g.Printf("%s", something) would perhaps be better
expressed like g.Print(something) or g.WriteString(something…dmitshur opened a change golang.org/x/exp/rand: fix printf(var) mistake detected by latest printf checker4d
For golang/go#69267.dmitshur opened a change golang.org/x/benchmarks/...: fix printf(var) mistakes detected by latest printf checker4d
Used %q instead of %s when reporting an unexpected body to make
potential non-printable characters easier to see.
For golang/go#69267.dmitshur opened a change golang.org/x/text/...: fix printf(var) mistakes detected by latest printf checker4d
The CodeWriter.WriteComment method is odd. It calls fmt.Sprintf
on its arguments so the caller doesn't need to, but isn't named
something like WriteCommentf as I'd expect. I tried renaming it,
but it…dmitshur commented on golang.org/x/build/internal/task: update the gopls version in vscode-go project4d
It's #69267; rebasing past CL 610816 will fix them.dmitshur opened a change golang.org/x/net/websocket: fix printf(var) mistake detected by latest printf checker4d
For golang/go#69267.dmitshur commented on all: fix printf(var) mistakes newly found in golang.org/x repos4d
List of golang.org/x repos that need attention:
- [x] x/build (resolved in [CL 610816](https://go.dev/cl/610816))
- [x] x/crypto (resolved in [CL 610797](https://go.dev/cl/610797))
- x/benchmark…dmitshur opened a change golang.org/x/build/...: fix printf(var) mistakes detected by latest printf checker4d
All of these fmt.Sprintf calls aren't needed.
For golang/go#69267.dmitshur commented on vendor/golang.org/x/tools: update to v0.24.1-0.20240904143311-70f56264139c4d
Sent CL 610797 for x/crypto.
It looks like other x/ repos need similar attention, filed #69267 to track that.dmitshur opened an issue all: fix printf(var) mistakes newly found in golang.org/x repos4d
Some golang.org/x repos have new findings from issue #68796 being resolved.
This issue is to track fixing them all.
CC @adonovan.dmitshur opened a change golang.org/x/crypto/...: fix printf(var) mistakes detected by latest printf checker4d
These were problematic but previously easy to miss. They're now
easy to spot thanks to build failures at Go tip as of CL 610736.
For golang/go#68796.dmitshur commented on golang.org/x/build: add LUCI aix-ppc64 builder4d
Thanks for working on this Paul. From what I can tell this case (`cas` failing to build for aix/ppc64) is the only known outstanding issue for this port. It's a good idea to check ahead for possible …dmitshur commented on golang.org/x/website: first example of race_detector doc does not work for newest versions4d
Thanks for reporting.
CC @dvyukov, @ianlancetaylor.dmitshur commented on cmd/go: build fails when run via QEMU for linux/amd64 running on linux/arm644d
Do you think this is this similar or related to issue #68976? (It wasn't listed in the comment above, but it feels similar from a very quick look.)
CC @prattmic, @matloob.dmitshur commented on crypto/tls: no way to check if a connection uses x25519Kyber768Draft004d
CC @FiloSottile, @golang/security.dmitshur commented on cmd/go: go build -asan may mis-parse gcc compiler version in a non-English environment4d
CC @matloob, @ianlancetaylor.dmitshur commented on golang.org/x/playground: buttons Format and Share look disabled in dark theme4d
Thanks for reporting this. From a quick look, this might actually be a bug that affects only the "auto" mode. I can reproduce your screenshot when the theme toggle is set to "auto":
<img width="36…dmitshur commented on golang.org/x/playground: buttons Format and Share look disabled in dark theme4d
CC @toothrot, @golang/tools-team.dmitshur commented on cmd/go: GO111MODULE does not invalidate test cache4d
CC @matloob, @samthanawalla.dmitshur commented on golang.org/x/crypto/ssh: MaxAuthTries error log overwrite PasswordCallback error4d
CC @drakkan.dmitshur commented on log/slog: examples can't be run on playground4d
CC @jba.dmitshur closed an issue encoding/xml: invalid characters in comments, processing instructions, or directives [1.22 backport]4d
This backport issue has been in WaitingForInfo state because it's not actionable until the upstream issue has a resolution. Closing for now, it's easy enough to re-open or create new backport issues …dmitshur closed an issue encoding/xml: invalid characters in comments, processing instructions, or directives [1.23 backport]4d
This backport issue has been in WaitingForInfo state because it's not actionable until the upstream issue has a resolution. Closing for now, it's easy enough to re-open or create new backport issues …dmitshur reviewed +2 on golang.org/x/tools/go.mod: for consistency with other repos, use 1.22.0 in go.mod4d
Thanks. While go1.22.0 is a good starting point (upgraded recently in CL 610435 from its previous value of 1.9), as discussed offline, you can still manually pick a newer 1.22 minor release if there'…dmitshur commented on cmd/vet: broken with GODEBUG=gotypesalias=14d
Checking on this issue as it's a release blocker. Any updates? Thanks.dmitshur commented on golang.org/x/scratch/...: fix build4d
Thanks.dmitshur commented on golang.org/x/playground/...: use the previous major Go release to bootstrap the build4d
Thanks.
The other two deploy files (including for tip playground) use `latestgo -prev` for the bootstrap, as the commit message says. This one leaves `-prev` out, which seems unintentional.
That sa…dmitshur commented on golang.org/x/tools/...: with 1.23 out, update Go directive to Go 1.224d
(1 comment)
Fortunately this case was just a matter of me reading "default GODEBUG ..." and leaving a quick comment to pause Auto-Submit and check it's still true after the 1.19 -> newer go version …dmitshur commented on golang.org/x/tools/...: with 1.23 out, update Go directive to Go 1.224d
(1 comment)
Ah, gotypesalias still defaults to the same value in 1.22 too, it changes in 1.23.dmitshur commented on golang.org/x/tools/...: with 1.23 out, update Go directive to Go 1.224d
(1 comment)
Isn't this comment out of date with the new go directive value?dmitshur commented on golang.org/x/build: add LUCI plan9-arm builder5d
@0intro https://ci.chromium.org/ui/p/golang/builders/luci.golang.ci/gotip-plan9-arm reports that the plan9-arm builder is offline.dmitshur opened a change golang.org/x/scratch/...: fix build5d
Add a wasm build constraint to a WebAssembly-specific command.
Encountering an empty go.mod file can be confusing for humans
and for builders. Remove it, it's probably not needed anymore.dmitshur commented on golang.org/x/build/internal/task: don't introduce toolchain directive in tagging workflow5d
Thanks.dmitshur reviewed +2 on cmd: use built-in clear for maps instead of range+delete5d
Thanks.
This was previously looping over e.cachedVals and deleting from e.cache, while the new code always clears e.cache. It might very well be equivalent and simpler code if e.cachedVals is guaran…dmitshur reviewed +2 on golang.org/x/playground/...: update Go versions in Dockerfiles5d
Thanks. At some point it'll be worth going to a newer Debian release, too.dmitshur opened a change golang.org/x/build/main.star: make 1.19 and 1.20 TOOLS_GO_BRANCHES trybots optional5d
We still want to be able to trigger them in the very immediate future,
but they no don't need to be included by default and block submission.
For golang/go#65917.dmitshur commented on golang.org/x/build/main.star: drop 1.19 and 1.20 from TOOLS_GO_BRANCHES5d
Resolved.
Thanks.dmitshur reviewed +2 on cmd: use built-in min/max instead of bespoke versions5d
Thanks.dmitshur commented on os: revert "Getwd: fallback to slow method on ENAMETOOLONG"5d
Thanks.dmitshur closed a change os: revert "Getwd: fallback to slow method on ENAMETOOLONG"5d
CL 609579 fixed forward, this shouldn't be needed anymore.