Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
Skip to content

Instantly share code, notes, and snippets.

@notwaldorf

notwaldorf/1-creating-a-pony-button.mm Secret

Last active August 29, 2015 14:27
Show Gist options
  • Save notwaldorf/9dda1a00709cc24a5b02 to your computer and use it in GitHub Desktop.
Save notwaldorf/9dda1a00709cc24a5b02 to your computer and use it in GitHub Desktop.
Download ZIP
Raw
1-creating-a-pony-button.mm
// Note, this was added right below
// https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/ui/cocoa/profiles/profile_chooser_controller.mm&l=1978
// Add a very important demo button. I found the icon by slaving through
// the icons in /chrome/app/theme, and finding out what the resource ID
// was in theme_resources.grd :)
NSButton* ponyButton =
[self hoverButtonWithRect:viewRect
text:@"Can I have a pony?"
imageResourceId:IDR_STAR_LIT
action:@selector(goPoniesGo:)];
viewRect.origin.y = NSMaxY([ponyButton frame);
[container addSubview:ponyButton];
// These lines are the last lines in the method, already there
[container setFrameSize:NSMakeSize(rect.size.width, viewRect.origin.y)];
return container.autorelease();
Raw
2-adding-the-go-ponies-go-handler.mm
- (IBAction)goPoniesGo:(id)sender{
LOG(ERROR) << "You get a pony, and you get a pony, and YOU get a pony";
}
Raw
3-implementing-the-go-ponies-go-handler.mm
- (IBAction)goPoniesGo:(id)sender{
LOG(ERROR) << "You get a pony, and you get a pony, and YOU get a pony";
chrome::ShowSingletonTab(browser_, GURL(http://canihaveapony.com));
}
Raw
4-sample-CL-description.text
# Enter a description of the change
# This will be displayed on the codereview site.
# The first line will also be used as the subject of the review.
[Mac] Add a pony button to the avatar bubble.
Because everyone should get a pony.
BUG=12345
TEST=Start Chrome with --enable-new-avatar-menu. Click on the profile
button. The avatar menu should have a "Can I have a pony" button, which
should give you a pony in a new tab when clicked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment