Redis doc #394
Merged
Redis doc #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't bother reviewing all the merged changes. Just the launch_cloud.md file. |
kmoscoe
commented
May 17, 2024
kmoscoe
commented
May 17, 2024
dwnoble
approved these changes
May 20, 2024
custom_dc/launch_cloud.md
Outdated
|
|
||
| We recommend that you use a caching layer to improve the performance of your database. We recommend [Google Cloud Redis Memorystore](https://cloud.google.com/memorystore), a fully managed solution, which will boost the performance of both natural-language searches and regular database lookups in your site. Redis Memorystore runs as a standalone instance in a virtual private cloud (VPC) network, to which your Cloud Run service connects using a [VPC connector](https://cloud.google.com/vpc/docs/serverless-vpc-access). | ||
|
|
||
| In the following procedures, we show you how to create a Redis instance in your project's "default" VPC network. You may wish to set up your own new VPC network; if so, follow the documentation in [Create and manage VPC networks](https://cloud.google.com/vpc/docs/create-modify-vpc-networks) substitute that network name for `default` throughout these procedures. |
There was a problem hiding this comment.
technically the redis instance doesn't live in the customer's VPC network, it lives in a Google-managed VPC, and connects to the customer's network ("default" or otherwise) via direct peering
There was a problem hiding this comment.
Might be sufficient to something like say: "we show you how to create a Redis instance that connects to your project's "default" VPC network."
There was a problem hiding this comment.
Thanks for this; I knew I didn't have it quite right. :-) PTAL.
| In the following procedures, we show you how to create a Redis instance in your project's "default" VPC network. You may wish to set up your own new VPC network; if so, follow the documentation in [Create and manage VPC networks](https://cloud.google.com/vpc/docs/create-modify-vpc-networks) substitute that network name for `default` throughout these procedures. | ||
|
|
||
| ### Step 1: Create the Redis instance | ||
|
|
There was a problem hiding this comment.
Maybe mention this a sample configuration, and can be tuned as needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.