Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix issue with float #6155

Merged
merged 1 commit into from
Mar 18, 2024
Merged

fix: fix issue with float #6155

merged 1 commit into from
Mar 18, 2024

Conversation

JoanFM
Copy link
Member

@JoanFM JoanFM commented Mar 18, 2024

Goals:

  • resolves #ISSUE-NUMBER

  • ...

  • ...

  • ...

  • ...

  • check and update documentation. See guide and ask the team.

@github-actions github-actions bot added size/XS area/core This issue/PR affects the core codebase labels Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.18%. Comparing base (176f953) to head (374f604).
Report is 3 commits behind head on master.

Files Patch % Lines
jina/serve/runtimes/helper.py 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6155      +/-   ##
==========================================
- Coverage   75.02%   74.18%   -0.85%     
==========================================
  Files         152      152              
  Lines       14100    14102       +2     
==========================================
- Hits        10578    10461     -117     
- Misses       3522     3641     +119     
Flag Coverage Δ
jina 74.18% <0.00%> (-0.85%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JoanFM JoanFM marked this pull request as ready for review March 18, 2024 09:32
@github-actions github-actions bot added the area/testing This issue/PR affects testing label Mar 18, 2024
@JoanFM JoanFM merged commit ade9084 into master Mar 18, 2024
127 of 130 checks passed
@JoanFM JoanFM deleted the fix-issue-with-floats branch March 18, 2024 10:30
@JoanFM JoanFM mentioned this pull request Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/core This issue/PR affects the core codebase area/testing This issue/PR affects testing size/S size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

float being checked as a list Flow with http doesn't support docarray float attribute
1 participant