Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: executor to azure custom container #6159

Merged
merged 2 commits into from
Apr 2, 2024
Merged

feat: executor to azure custom container #6159

merged 2 commits into from
Apr 2, 2024

Conversation

zac-li
Copy link
Member

@zac-li zac-li commented Mar 29, 2024 •
edited

Notes

  • This PR enables executor to run as a Fastapi app in Azure container.
  • Unlike Sagemaker, multiple endpoints can be exposed in one container (no validation like SageMaker would be called).
  • Tests structure is also restructured; now both sagemaker and azure tests are under csp folder and sharing the same executor fixtures.

@github-actions github-actions bot added size/M area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing labels Mar 29, 2024
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024 •
edited

Codecov Report

Attention: Patch coverage is 57.89474% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 72.76%. Comparing base (b5793f0) to head (d7d3299).
Report is 2 commits behind head on master.

Files Patch % Lines
jina/serve/runtimes/servers/http.py 63.63% 4 Missing ⚠️
jina/serve/runtimes/asyncio.py 33.33% 2 Missing ⚠️
jina/serve/runtimes/worker/http_csp_app.py 0.00% 1 Missing ⚠️
jina/serve/runtimes/worker/request_handling.py 50.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6159      +/-   ##
==========================================
- Coverage   74.85%   72.76%   -2.09%     
==========================================
  Files         152      152              
  Lines       14142    14156      +14     
==========================================
- Hits        10586    10301     -285     
- Misses       3556     3855     +299
Flag Coverage Δ
jina 72.76% <57.89%> (-2.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zac-li zac-li changed the title (WIP) feat: executor to azure custom container feat: executor to azure custom container Mar 29, 2024
@zac-li zac-li marked this pull request as ready for review March 29, 2024 07:47
@JoanFM
Copy link
Member

JoanFM commented Apr 2, 2024

What is the difference between SageMaker and Azure HTTP server?

@zac-li zac-li enabled auto-merge (squash) April 2, 2024 09:49
@JoanFM JoanFM disabled auto-merge April 2, 2024 09:52
@JoanFM JoanFM merged commit b04f750 into master Apr 2, 2024
127 of 130 checks passed
@JoanFM JoanFM deleted the feat-azure-support branch April 2, 2024 09:52
@JoanFM JoanFM mentioned this pull request Apr 2, 2024
Closed
@JoanFM JoanFM mentioned this pull request Jul 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoanFM JoanFM JoanFM approved these changes

@hanxiao hanxiao Awaiting requested review from hanxiao hanxiao is a code owner

@nan-wang nan-wang Awaiting requested review from nan-wang nan-wang is a code owner

Assignees
No one assigned
Labels
area/cicd This issue/PR affects the cicd pipeline area/core This issue/PR affects the core codebase area/helper This issue/PR affects the helper functionality area/housekeeping This issue/PR is housekeeping area/testing This issue/PR affects testing size/M
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zac-li @JoanFM