Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Create Task
Maniphest T127216

CompletionSuggester Beta Feature broken on Hebrew Wikipedia
Closed, ResolvedPublic
Actions

Description

The completion suggester beta feature on the Hebrew Wikipedia returns zero suggestions when enabled.

First reported by User:קיפודנח

ש: https://www.mediawiki.org/wiki/Help:CirrusSearch/CompletionSuggester#currently_broken_on_hewiki

Steps to reproduce:

  1. Visit https://he.wikipedia.org
  2. Log in
  3. Enable the beta feature
    1. For non hebrew-reading folks: https://he.wikipedia.org/wiki/מיוחד:העדפות#mw-prefsection-betafeatures is the link to the beta features preference pane.
    2. The completion suggester is the first checkbox.
  4. Search for something.
    1. My example is the phrase "Breaking Bad" or "שובר שורות"
  5. Nothing is suggested.

Disabling the beta feature and searching shows suggestions.

Related Objects
Search...

Event Timeline

CKoerner_WMF created this task.Feb 17 2016, 6:47 PM
CKoerner_WMF raised the priority of this task from to Needs Triage.
CKoerner_WMF updated the task description. (Show Details)
CKoerner_WMF added a project: Discovery-ARCHIVED.
CKoerner_WMF subscribed.
Restricted Application added subscribers: StudiesWorld, Aklapper. · View Herald TranscriptFeb 17 2016, 6:47 PM
CKoerner_WMF added projects: Beta-Feature, CirrusSearch.Feb 17 2016, 6:48 PM
CKoerner_WMF set Security to None.
• Deskana triaged this task as High priority.Feb 17 2016, 7:15 PM
• Deskana merged a task: T127201: CompletionSuggester (beta option) currently broken on hewiki.
• Deskana added a subscriber: Kipod.
• Deskana subscribed.

Not quite "Unbreak now!" because this is a beta feature, but it is still very high priority for us to fix.

• Deskana added a project: Discovery-Search (Current work).Feb 17 2016, 7:16 PM
• Deskana moved this task from Needs triage to On Sprint Board on the Discovery-ARCHIVED board.
• Deskana added a parent task: T121616: EPIC: Resolve technical or product blockers to enable us to do a more full rollout of the completion suggester.Feb 17 2016, 7:20 PM
dcausse subscribed.Feb 17 2016, 7:54 PM
eranroz subscribed.Feb 17 2016, 8:50 PM

Users were asked to disable the feature. If it isn't fixed in the near future I would suggest to disable the beta feature so users will not get bad impression.

dcausse claimed this task.Feb 17 2016, 10:04 PM
dcausse added a comment.Feb 17 2016, 10:07 PM

The index was not created properly, I will investigate. This is maybe due to the rolling restart last week. I created T127182 to make this process more robust.
I've updated it manually so it should work properly now.
I will double check other indices tomorrow.

dcausse closed this task as Resolved.Feb 17 2016, 10:07 PM
dcausse moved this task from Incoming to Needs Reporting on the Discovery-Search (Current work) board.
• Deskana added subscribers: Smalyshev, Mooeypoo, Amire80.Feb 18 2016, 5:03 AM

Thanks @dcausse!

@CKoerner_WMF Perhaps you could reach out to the Hebrew users informing them that we fixed the issue and that it was a temporary one which should never occur in a full release? I'm sure one of our Hebrew speakers (e.g. @Amire80, @Mooeypoo. @Smalyshev, etc.) would be willing to assist with a one-off English to Hebrew translation, if that would be helpful.

eranroz added a comment.Feb 18 2016, 5:31 AM

Thanks @dcausse .
@Deskana - Done see:
https://he.wikipedia.org/wiki/%D7%95%D7%99%D7%A7%D7%99%D7%A4%D7%93%D7%99%D7%94:%D7%93%D7%9C%D7%A4%D7%A7_%D7%99%D7%99%D7%A2%D7%95%D7%A5#.D7.94.D7.A9.D7.9C.D7.9E.D7.AA_.D7.A9.D7.9E.D7.95.D7.AA_.D7.A2.D7.A8.D7.9B.D7.99.D7.9D_.D7.91.D7.9E.D7.A0.D7.95.D7.A2_.D7.94.D7.97.D7.99.D7.A4.D7.95.D7.A9_.D7.95.D7.91.D7.A2.D7.A8.D7.99.D7.9B.D7.94 (In google translate you will get "Completing the names of the search engine values ​​and editing" :) )

Smalyshev added a comment.Feb 18 2016, 6:13 AM

@eranroz Thanks! Works for me too with beta enabled now.

• Deskana added a comment.Feb 18 2016, 6:19 AM

@eranroz Awesome! Thank you so much!

Kipod added a comment.Feb 19 2016, 7:53 PM

may be a good idea to fallback on "old" suggestions if CompletionSuggester returns empty list, regardless of the reason (software bug, broken index, some server is down, whatever), at least as long as the "old" suggestions still available..

peace.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits