Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Create Task
Maniphest T157442

Investigate why (and fix) JSON representation of entity on Special:EntityData drops the repository name prefix from foreign entity used in the statement
Closed, InvalidPublic
Actions

Description

Noticed while testing federation code. Test setup was: Repo 1 ("main") provides properties, Repo 2 provides items.
When using properties from "main" on repo 2, statement data for the item is missing the repository prefix, see excerpt from the "claims" part of item data:

{"P2":[{"mainsnak":{"snaktype":"value","property":"P2","datavalue":{"value":{"entity-type":"item","numeric-id":2,"id":"Q2"}

Repository name is correctly stored in the database.

First suspect is that while StatementModificationHelper::getEntityIdFromString is parsing the serialized ID, the parser for some reason drops the prefix (maybe maps it to an empty prefix).
This behaviour must be investigated. If fixing the problem turns out to be complex, please file a separate ticket outlining the solution.

Patches for review:

Related Objects
Search...

StatusSubtypeAssignedTask
 DeclineddchenT118706 Conduct heuristic evaluation of image upload and insert flow in VisualEditor
 OpenNoneT115858 Design improvements for mw.ForeignStructuredUpload.BookletLayout
 OpenNoneT115865 Insert image in content immediately after it's uploaded, skipping the "General settings" step
 DuplicateNoneT115864 Figure out if the description of the image can be used as the caption on-wiki
 OpenFeatureNoneT53032 When inserting an image, set its caption by default to be the Commons image description
 OpenFeatureNoneT39534 Wikimedia Commons should support searching by color
 DuplicateNoneT39535 Wikimedia Commons should support filtering by color
 ResolvedNoneT19503 Provide metadata support on Wikimedia Commons
 ResolvedNoneT51662 VisualEditor: Use Multimedia/Wikidata's proposed rich structured meta-data in the image insertion dialog
 ResolvedNoneT68108 [Epic] Store media information for files on Wikimedia Commons as structured data
 OpenNoneT109579 [Epic] Give more sister projects access to Wikidata
 OpenNoneT187900 There is no way to reference a specific quote on Wikiquote
 StalledNoneT71753 [Story] Wikibase / Wikidata support on Wikiquote
 ResolvedLydia_PintscherT146637 Wikidata 2016 Q4 goals
 ResolvedLydia_PintscherT150179 Wikidata 2017 Q1 goals
 ResolvedLydia_PintscherT76007 [Epic] add ability to link/refer to foreign items and properties (federation)
 ResolvedLydia_PintscherT149580 Allow access to entity data stored on "foreign" repositories (federation)
 InvaliddanielT157442 Investigate why (and fix) JSON representation of entity on Special:EntityData drops the repository name prefix from foreign entity used in the statement
 ResolvedthiemowmdeT157965 [Task] Release Wikibase DataModel 7.0.0

Event Timeline

WMDE-leszek created this task.Feb 7 2017, 1:07 PM
WMDE-leszek renamed this task from Investigate why (and fix) Api\SetClaim drops the repostiory name prefix from foreign entity used in the statement to Investigate why (and fix) JSON representation of entity on Special:EntityData drops the repostiory name prefix from foreign entity used in the statement.Feb 7 2017, 2:47 PM
WMDE-leszek updated the task description. (Show Details)
daniel added a comment.Feb 8 2017, 6:50 PM

I ran into several issues while trying to investigate this. One of them is related to the fact that we use serialiez/unserialiez to clone statements, and serialization of Snaks and EntityIdValue uses numeric IDs. Patch on github: https://github.com/wmde/WikibaseDataModel/pull/716

Ricordisamoa renamed this task from Investigate why (and fix) JSON representation of entity on Special:EntityData drops the repostiory name prefix from foreign entity used in the statement to Investigate why (and fix) JSON representation of entity on Special:EntityData drops the repository name prefix from foreign entity used in the statement.Feb 9 2017, 10:05 AM
Ricordisamoa updated the task description. (Show Details)
thiemowmde assigned this task to daniel.Feb 9 2017, 4:51 PM
thiemowmde updated the task description. (Show Details)
thiemowmde moved this task from Proposed to Review on the Wikidata-Former-Sprint-Board board.
thiemowmde moved this task from incoming to in progress on the Wikidata board.
thiemowmde subscribed.
thiemowmde added a subtask: T157965: [Task] Release Wikibase DataModel 7.0.0.Feb 13 2017, 2:17 PM
thiemowmde added a project: Patch-For-Review.
thiemowmde updated the task description. (Show Details)
WMDE-leszek added a comment.EditedFeb 13 2017, 4:05 PM

Breaking news: this seems to be working on current master (tested locally, 9dcffbca5a4f91915e872cc998039c5c57aabd63) but also on slightly older master (on labs instance, running a99a802cd4621ea5a21bc31d1542a60b5f7d0144.
Now I really need to investigate what was wrong before so it didn't work, as it seems changes in serializers might not be relevant here? (although I believe they're still valid changes).

EDIT: I am very confused. The above comment might not be valid. The local version I am trying out seems to work OK, and I am confused what Labs instance shows me (sometimes it prefixes the output sometimes not). I will further into that.

WMDE-leszek moved this task from Review to Doing on the Wikidata-Former-Sprint-Board board.Feb 14 2017, 12:26 PM
WMDE-leszek closed this task as Invalid.Mar 15 2017, 8:38 AM

The problem with missing prefix in the JSON data seems to not be happening any mare with the current master of Wikibase git (using current Data Model 6.3.1).
I was trying to track down if any changes to Wikibase code in last few weeks fixed it but failed to find anything. I tend to think it was some configuration problem, or maybe something was cached on Labs (this is where the issue was originally discovered). I didn't see it happening for few weeks, and cannot reproduce it.

Problem Daniel ran into seems unrelated to the prefix issue, as are in my opinion fixes in the Data Model. That issue might have been somewhat related to Wikibase using wrong serializer for entities: T160426.

As the missing prefix in JSON data issue seems to not be a problem any more, I close this ticket. It should be re-opened if the problems appears again, then we should be able to reproduce it.

WMDE-leszek moved this task from Doing to Done on the Wikidata-Former-Sprint-Board board.Mar 15 2017, 8:38 AM
WMDE-leszek mentioned this in T160516: Wikibase crashes when serialized data of the entity using foreign entities is loaded from cache..Mar 15 2017, 12:46 PM
thiemowmde closed subtask T157965: [Task] Release Wikibase DataModel 7.0.0 as Resolved.Mar 28 2017, 8:46 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits