Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Create Task
Maniphest T181457

[wmf.8-minor] 'New translation' search displays previous language selection in the warning "No pages found for ..."
Closed, ResolvedPublic
Actions

Description

  1. On the Content translation page click on 'New translation'
  2. Enter the search criteria that cannot be found in the selected language; you may use some random string of characters.
  3. The user message appears informing you that e.g. " No pages found for "443j24p3d" in English".
  4. Select a different language - the selection will be changed, but the message will not be changed: " No pages found for "443j24p3d" in English"

Screen Shot 2017-11-27 at 4.39.30 PM.png (290×782 px, 22 KB)

Note: The issue is minor - if a page is found, all the suggestions will be displayed correctly according to the newly selected language.

Details

SubjectRepoBranchLines +/-
Fix no result messages on "New translation" dialogmediawiki/extensions/ContentTranslationmaster+188 -164
Customize query in gerrit

Event Timeline

Etonkovidova created this task.Nov 28 2017, 12:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 28 2017, 12:44 AM
• Petar.petkovic claimed this task.Nov 28 2017, 10:31 AM
• Petar.petkovic added a project: User-Petar.petkovic.
Amire80 moved this task from Needs Triage to Bugs on the ContentTranslation board.Nov 28 2017, 11:49 AM
gerritbot subscribed.Nov 30 2017, 11:04 PM

Change 394492 had a related patch set uploaded (by Petar.petkovic; owner: Petar.petkovic):
[mediawiki/extensions/ContentTranslation@master] Fix no result messages on "New translation" dialog

https://gerrit.wikimedia.org/r/394492

gerritbot added a project: Patch-For-Review.Nov 30 2017, 11:04 PM
• Petar.petkovic edited projects, added Language-2017-Oct-Dec; removed User-Petar.petkovic.Nov 30 2017, 11:04 PM
• Petar.petkovic moved this task from Backlog to In Review on the Language-2017-Oct-Dec board.
gerritbot added a comment.Dec 29 2017, 1:58 PM

Change 394492 merged by jenkins-bot:
[mediawiki/extensions/ContentTranslation@master] Fix no result messages on "New translation" dialog

https://gerrit.wikimedia.org/r/394492

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-01-02 (1.31.0-wmf.15)).Dec 29 2017, 2:00 PM
• Petar.petkovic removed a project: Patch-For-Review.Dec 29 2017, 2:00 PM
• Petar.petkovic moved this task from In Review to QA on the Language-2017-Oct-Dec board.
Etonkovidova added a comment.Jan 2 2018, 2:14 AM

Checked in cx-testing - the fix works according to the description in https://gerrit.wikimedia.org/r/394492.

Etonkovidova closed this task as Resolved.Jan 2 2018, 2:15 AM
• Petar.petkovic moved this task from QA to Done on the Language-2017-Oct-Dec board.Jan 2 2018, 2:23 AM
RandomDSdevel awarded a token.Feb 13 2018, 2:34 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits