Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Create Task
Maniphest T182110

Only update constraints table when constraint statements were edited
Closed, ResolvedPublic
Actions

Description

Now that we have compact diffs in EntityChange (T113468), we can use those to only schedule an UpdateConstraintsTableJob when the constraint statements (P​2302 on Wikidata) were actually edited (which was previously not possible due to T163465).

Patch-For-Review:

Details

SubjectRepoBranchLines +/-
Add tests for WikibaseQualityConstraintsHooks::isConstraintStatementsChangemediawiki/extensions/WikibaseQualityConstraintsmaster+113 -5
Rename WikibaseQualityConstraintsHooks functionmediawiki/extensions/WikibaseQualityConstraintsmaster+2 -2
Only schedule job if constraint statements were editedmediawiki/extensions/WikibaseQualityConstraintsmaster+14 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lucas_Werkmeister_WMDE created this task.Dec 5 2017, 3:27 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 5 2017, 3:27 PM
Lucas_Werkmeister_WMDE mentioned this in T182105: Store constraint check results and tracked entities in object cache.Dec 5 2017, 3:28 PM
gerritbot subscribed.Dec 5 2017, 3:33 PM

Change 392066 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Only schedule job if constraint statements were edited

https://gerrit.wikimedia.org/r/392066

gerritbot added a project: Patch-For-Review.Dec 5 2017, 3:33 PM
thiemowmde triaged this task as Medium priority.Dec 5 2017, 3:54 PM
thiemowmde added a subtask: T113468: [Task] Use compact representation of diffs in EntityChange..
Lucas_Werkmeister_WMDE added a project: Wikidata-Sprint-2017-12-06.Dec 5 2017, 4:56 PM
Lucas_Werkmeister_WMDE moved this task from Backlog to Review on the Wikidata-Sprint-2017-12-06 board.
gerritbot added a comment.Dec 5 2017, 5:35 PM

Change 392066 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Only schedule job if constraint statements were edited

https://gerrit.wikimedia.org/r/392066

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Dec 5 2017, 6:00 PM
gerritbot added a comment.Dec 5 2017, 7:19 PM

Change 395589 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename WikibaseQualityConstraintsHooks function

https://gerrit.wikimedia.org/r/395589

gerritbot added a comment.Dec 5 2017, 7:19 PM

Change 395590 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for WikibaseQualityConstraintsHooks::isConstraintStatementsChange

https://gerrit.wikimedia.org/r/395590

Lucas_Werkmeister_WMDE updated the task description. (Show Details)Dec 5 2017, 7:21 PM
gerritbot added a comment.Dec 5 2017, 10:06 PM

Change 395589 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Rename WikibaseQualityConstraintsHooks function

https://gerrit.wikimedia.org/r/395589

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2017-12-12 (1.31.0-wmf.12)); removed MW-1.31-release-notes (WMF-deploy-2017-12-05 (1.31.0-wmf.11)).Dec 5 2017, 11:00 PM
gerritbot added a comment.Dec 6 2017, 12:43 PM

Change 395590 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Add tests for WikibaseQualityConstraintsHooks::isConstraintStatementsChange

https://gerrit.wikimedia.org/r/395590

Lucas_Werkmeister_WMDE closed this task as Resolved.Dec 6 2017, 12:48 PM
Lucas_Werkmeister_WMDE updated the task description. (Show Details)
Lucas_Werkmeister_WMDE moved this task from Review to Done on the Wikidata-Sprint-2017-12-06 board.
Lucas_Werkmeister_WMDE moved this task from incoming to in progress on the Wikidata board.
Lucas_Werkmeister_WMDE moved this task from Backlog to DONE on the Wikibase-Quality board.
Ladsgroup closed subtask T113468: [Task] Use compact representation of diffs in EntityChange. as Resolved.Dec 7 2017, 6:09 PM
Lucas_Werkmeister_WMDE mentioned this in T183159: Only invalidate cached constraint check results when property constraints are edited.Dec 18 2017, 5:19 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits