Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Create Task
Maniphest T188166

Update extensions to extend PHPUnit\Framework\TestCase
Closed, ResolvedPublic
Actions

Description

Instead of extending PHPUnit_Framework_TestCase, extensions need to extend from PHPUnit\Framework\TestCase. The latter is available as a forwards-compat shim in PHPUnit 4.8.36 so it is safe to migrate over before PHPUnit 6 happens. Extensions using MediaWiki-CodeSniffer 16.0.0 will have had this automatically taken care of.

https://codesearch.wmflabs.org/search/?q=PHPUnit_Framework_TestCase&i=nope&files=&repos=

Details

SubjectRepoBranchLines +/-
Use namespaced PHPUnit\Framework\TestCaseoperations/mediawiki-configmaster+8 -8
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/Wikibasemaster+42 -42
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/Wikibasemaster+335 -485
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/WikibaseQualityConstraintsmaster+4 -4
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/WikibaseQualitymaster+3 -6
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/ArticlePlaceholdermaster+1 -2
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/Cognatemaster+2 -1
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/InterwikiSortingmaster+1 -1
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/DonationInterfacemaster+3 -3
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/MultiMapsmaster+8 -8
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/Numbertextmaster+1 -1
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/MassActionmaster+6 -12
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/JsonDatamaster+1 -1
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/PhpTagsFunctionsmaster+8 -8
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/PhpTagsStoragemaster+1 -1
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/PhpTagsWikimaster+1 -1
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/SemanticDrilldownmaster+1 -2
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/BlueSpiceFoundationmaster+14 -15
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/WikibaseQualityConstraintsmaster+37 -42
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/PhpTagsSMWmaster+1 -2
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/PhpTagsMapsmaster+9 -10
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/Lingomaster+7 -8
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/WikibaseQualityExternalValidationmaster+8 -16
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/WikibaseMediaInfomaster+17 -29
Use namespaced PHPUnit\Framework\TestCase in MockOresServiceBuildermediawiki/extensions/ORESmaster+2 -2
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/Scribuntomaster+1 -1
Use namespaced PHPUnit\Framework\TestCasemediawiki/extensions/OAuthmaster+7 -7
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Legoktm created this task.Feb 24 2018, 6:27 AM
Legoktm updated the task description. (Show Details)Feb 24 2018, 6:38 AM
gerritbot added a project: Patch-For-Review.Feb 24 2018, 6:43 AM
Legoktm mentioned this in rEWBI756e11227775: Use namespaced PHPUnit\Framework\TestCase.Feb 24 2018, 6:56 AM
Legoktm added a comment.Feb 24 2018, 8:48 AM

https://gerrit.wikimedia.org/r/#/q/bug:T188166+(status:open+OR+status:merged)

ReleaseTaggerBot added a project: MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Feb 24 2018, 10:00 AM
EddieGP unsubscribed.Feb 25 2018, 12:04 AM
gerritbot added a comment.Mar 23 2018, 5:27 PM

Change 421586 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/DonationInterface@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421586

gerritbot added a comment.Mar 23 2018, 5:43 PM

Change 421588 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[operations/mediawiki-config@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421588

gerritbot added a comment.Mar 23 2018, 5:44 PM

Change 421586 merged by jenkins-bot:
[mediawiki/extensions/DonationInterface@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421586

gerritbot added a comment.Mar 23 2018, 5:45 PM

Change 421589 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/InterwikiSorting@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421589

gerritbot added a comment.Mar 23 2018, 5:51 PM

Change 421590 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Cognate@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421590

gerritbot added a comment.Mar 23 2018, 5:53 PM

Change 421591 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/ArticlePlaceholder@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421591

Umherirrender mentioned this in rEIWS405a3b71c634: Use namespaced PHPUnit\Framework\TestCase.Mar 23 2018, 5:55 PM
ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)); removed MW-1.31-release-notes (WMF-deploy-2018-02-27 (1.31.0-wmf.23)).Mar 23 2018, 6:00 PM
Umherirrender mentioned this in rECOGeb479ab652f5: Use namespaced PHPUnit\Framework\TestCase.Mar 23 2018, 6:01 PM
gerritbot added a comment.Mar 23 2018, 6:19 PM

Change 421596 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WikibaseQuality@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421596

gerritbot added a comment.Mar 23 2018, 6:25 PM

Change 421598 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/WikibaseQualityConstraints@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421598

Umherirrender mentioned this in rECOG6b4832f171a0: Use namespaced PHPUnit\Framework\TestCase.Mar 23 2018, 6:31 PM
gerritbot added a comment.Mar 23 2018, 7:42 PM

Change 421611 had a related patch set uploaded (by Umherirrender; owner: Umherirrender):
[mediawiki/extensions/Wikibase@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421611

gerritbot added a comment.Mar 24 2018, 6:56 PM

Change 421590 merged by jenkins-bot:
[mediawiki/extensions/Cognate@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421590

gerritbot added a comment.Mar 24 2018, 7:03 PM

Change 421591 merged by jenkins-bot:
[mediawiki/extensions/ArticlePlaceholder@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421591

gerritbot added a comment.Mar 24 2018, 7:04 PM

Change 421589 merged by jenkins-bot:
[mediawiki/extensions/InterwikiSorting@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421589

gerritbot added a comment.Mar 25 2018, 4:20 PM

Change 421598 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQualityConstraints@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421598

gerritbot added a comment.Mar 25 2018, 4:20 PM

Change 421596 merged by jenkins-bot:
[mediawiki/extensions/WikibaseQuality@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421596

gerritbot added a comment.Mar 26 2018, 8:26 AM

Change 421611 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421611

gerritbot added a comment.Apr 8 2018, 2:39 AM

Change 424840 had a related patch set uploaded (by Legoktm; owner: Legoktm):
[mediawiki/extensions/Wikibase@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/424840

Legoktm added a comment.Apr 8 2018, 2:40 AM

According to codesearch, https://gerrit.wikimedia.org/r/424840 should be the last usage in Wikimedia Git for MediaWiki extensions.

gerritbot added a comment.Apr 8 2018, 10:08 AM

Change 424840 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/424840

ReleaseTaggerBot edited projects, added MW-1.31-release-notes (WMF-deploy-2018-04-10 (1.31.0-wmf.29)); removed MW-1.31-release-notes (WMF-deploy-2018-03-27 (1.31.0-wmf.27)).Apr 8 2018, 11:00 AM
Legoktm closed this task as Resolved.Apr 8 2018, 5:58 PM
gerritbot added a comment.Apr 12 2018, 11:02 PM

Change 421588 merged by jenkins-bot:
[operations/mediawiki-config@master] Use namespaced PHPUnit\Framework\TestCase

https://gerrit.wikimedia.org/r/421588

Umherirrender mentioned this in rECOG34302b3d6bf2: Final NoteDb migration updates.Jun 8 2018, 11:56 PM
Legoktm mentioned this in rEWBIf15575a082f1: Final NoteDb migration updates.Jun 9 2018, 5:57 PM
Umherirrender mentioned this in rEIWScbbf62ccbd7e: Final NoteDb migration updates.Jun 10 2018, 2:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits