In the namespaces where Help panel is enabled in reading context, the Help panel has a smaller size (e.g. 188x32):
When a user switches to editing - the Help panel size increases to 215x36:
Etonkovidova | |
Mar 4 2019, 11:25 PM |
F28326903: Screen Shot 2019-03-04 at 2.48.24 PM.png | |
Mar 4 2019, 11:25 PM |
F28326908: Screen Shot 2019-03-04 at 2.48.40 PM.png | |
Mar 4 2019, 11:25 PM |
In the namespaces where Help panel is enabled in reading context, the Help panel has a smaller size (e.g. 188x32):
When a user switches to editing - the Help panel size increases to 215x36:
Subject | Repo | Branch | Lines +/- | |
---|---|---|---|---|
Make cta the same size in reading and edit modes | mediawiki/extensions/GrowthExperiments | master | +1 -0 |
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | MMiller_WMF | T206711 [EPIC] Growth: help panel | |||
Resolved | • kostajh | T215664 Help panel: show in additional contexts | |||
Resolved | BUG REPORT | SBisson | T217612 [minor] Help panel CTA size inconsistent between reading and editor context |
Hey @MMiller_WMF I am placing this in your column to decide what you would like to do with it.
@JTannerWMF -- I think we should work on this bug. I realize now that I had been noticing it, too, but couldn't put my finger on what it was. Perhaps we can discuss in Grooming meeting tomorrow where it should go.
font-size is what makes the difference here. Reading has 14px and edit has 16px. Which one do we want?
Change 497955 had a related patch set uploaded (by Sbisson; owner: Sbisson):
[mediawiki/extensions/GrowthExperiments@master] Make cta the same size in reading and edit modes
Change 497955 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Make cta the same size in reading and edit modes
@Etonkovidova @SBisson -- I still see this inconsistency in size in production. Do I need to clear my cache or something?
It won't be in production wikis until Thursday. Do you see inconsistent sizes on beta?
The patch was merged Thursday last week. It will be on our target wikis Thursday this week but it should be on testwiki later today.