WebVideoTranscodeJob fatal: Call to getStdout() on a non-object
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	Krinkle
	Jun 27 2019, 5:38 PM

Description

Error

Request URL: (jobrunners: videoscaler)
Request ID: eb4456d8425cf8b81799c7f5

message

BadMethodCallException: Call to a member function getStdout() on a non-object (null)

trace

#0 /srv/mediawiki/php-1.34.0-wmf.11/extensions/TimedMediaHandler/includes/WebVideoTranscode/WebVideoTranscodeJob.php(202): WebVideoTranscodeJob->midiToAudioEncode(array)
#1 /srv/mediawiki/php-1.34.0-wmf.11/extensions/EventBus/includes/JobExecutor.php(64): WebVideoTranscodeJob->run()
#2 /srv/mediawiki/rpc/RunSingleJob.php(76): JobExecutor->execute(array)
#3 {main}

Impact

The transcode job is not able to complete. Given the error appears deterministic, it might mean that some media files are unavailable to some groups of users.

Notes

Seen for the first time on 1.34.0-wmf.11. Not seen in the 30 days prior.

code (WebVideoTranscode.php)

	$shellOutput = $this->runShellExec( $cmdString, $retval );

	// Fluidsynth doesn't give error codes - $retval always stays 0
	if ( strpos( $shellOutput, "fluidsynth: error:" ) !== false ) {
		return $cmdString .
			"\n\nExitcode: $retval\nMemory: $wgTranscodeBackgroundMemoryLimit\n\n" .
			$cmd->getStdout();

Added in 19aabab261960d5a2 / https://gerrit.wikimedia.org/r/511015 (T20852, T135597).

Details

	Subject	Repo	Branch	Lines +/-
	Fix a broken error case handler in midi transcoding	mediawiki/extensions/TimedMediaHandler	wmf/1.34.0-wmf.11	+1 -1
	Fix a broken error case handler in midi transcoding	mediawiki/extensions/TimedMediaHandler	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T135597: Move MIDI to audio conversion from Score into TimedMediaHandler
Mentioned Here: T20852: Support inline player for MIDI files
T135597: Move MIDI to audio conversion from Score into TimedMediaHandler
rETMH19aabab26196: Transcode MIDI files to OGG Vorbis and MP3

Event Timeline

Krinkle created this task.Jun 27 2019, 5:38 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 27 2019, 5:38 PM

• brooke claimed this task.Jun 27 2019, 9:08 PM

Change 519525 had a related patch set uploaded (by Brion VIBBER; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@master] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519525

gerritbot added a project: Patch-For-Review.Jun 27 2019, 9:19 PM

Krinkle triaged this task as High priority.Jun 27 2019, 9:19 PM

Krinkle moved this task from Untriaged to Jun 2019 / 1.34.wmf.8+ on the Wikimedia-production-error board.

• brooke mentioned this in T135597: Move MIDI to audio conversion from Score into TimedMediaHandler.Jun 27 2019, 9:30 PM

Change 519528 had a related patch set uploaded (by Krinkle; owner: Brion VIBBER):
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.11] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519528

Krinkle moved this task from Jun 2019 / 1.34.wmf.8+ to Resolved on the Wikimedia-production-error board.Jun 27 2019, 9:32 PM

Change 519525 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@master] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519525

Mentioned in SAL (#wikimedia-operations) [2019-06-27T21:44:08Z] <brion> deploying fix for TMH jobqueue bug T226748

Change 519528 merged by jenkins-bot:
[mediawiki/extensions/TimedMediaHandler@wmf/1.34.0-wmf.11] Fix a broken error case handler in midi transcoding

https://gerrit.wikimedia.org/r/519528

Fix deployed. Should no longer cause fatal errors, but should log the transcoder output into the transcode table so we can review it later for suspicious commonalities.

ReleaseTaggerBot added a project: MW-1.34-notes (1.34.0-wmf.11; 2019-06-26).Jun 27 2019, 10:00 PM

Note a deployment typo caused this fix to not get deployed in fact. Whoops! Roan's fixing it now.

Mentioned in SAL (#wikimedia-operations) [2019-06-27T23:25:48Z] <brion> roan is fixing deploy of T226748 which failed to include the patch (whoops)

Mentioned in SAL (#wikimedia-operations) [2019-06-27T23:28:56Z] <catrope@deploy1001> Synchronized php-1.34.0-wmf.11/extensions/TimedMediaHandler/: T226748 (duration: 00m 50s)

Jdforrester-WMF removed a project: Patch-For-Review.Jun 28 2019, 1:38 AM

• mmodell changed the subtype of this task from "Task" to "Production Error".Aug 28 2019, 11:06 PM

WebVideoTranscodeJob fatal: Call to getStdout() on a non-objectClosed, ResolvedPublicPRODUCTION ERRORActions