Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Maniphest T264207

Lexeme: Most QUnit tests are not actually running
Closed, ResolvedPublic

Description

It appears as though most of the qunit tests registered for WikibaseLexeme are not running locally or in CI. Upon further inspection it appears that only the first test file registered through the QUnitTestModule option in extension.js is running.

Attempting to break the tests by removing parts of the test code also seems to not affect CI runs either. See patch 631190 for more info.

MediaWiki conditions:

  • WikibaseLexeme installed
  • Set $wgEnableJavaScriptTest to true in LocalSettings.php

To reproduce:

  1. Clone the broken tests patchset.
  2. Run the QUnit tests by going to Special:JavascriptTest in your local wiki OR by running npm run qunit in you mediawiki installation root directory
  3. Filter the test output for modules the should be registered with lexeme.

Current behaviour:

  • Tests are not failing with broken test example
  • Not all registered tests appear in the test result output.

Desired behaviour:

  • Tests are failing with broken test example
  • All registered test modules appear in the test result output.

Event Timeline

Change 641793 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Register all QUnit tests

https://gerrit.wikimedia.org/r/641793

Change 641793 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Register all QUnit tests

https://gerrit.wikimedia.org/r/641793