Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Create Task
Maniphest T273317

some users with access are unable to configure pending changes
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to Reproduce:
Try to configure pending changes, the PC options are greyed out.
When trying via the API, an access denied error is returned as well (see below)

Actual Results:

{ "error": { "code": "stabilize_denied", "info": "Permission denied.", "*": "See https://en.wikipedia.org/w/api.php for API usage. Subscribe to the mediawiki-api-announce mailing list at <https://lists.wikimedia.org/mailman/listinfo/mediawiki-api-announce> for notice of API deprecations and breaking changes." }, "servedby": "mw1363" }

Expected Results:
The operation will succeed

Details

SubjectRepoBranchLines +/-
Revert "Remove usages and hard deprecate User::changeable(By)Group"mediawiki/coremaster+5 -23
Run setup from MediaWikiServices hook.mediawiki/extensions/FlaggedRevsmaster+3 -5
Revert "Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group"""mediawiki/corewmf/1.36.0-wmf.28+5 -23
Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group""mediawiki/corewmf/1.36.0-wmf.28+0 -0
Revert "Remove usages and hard deprecate User::changeable(By)Group"mediawiki/corewmf/1.36.0-wmf.28+5 -23
Customize query in gerrit

Related Objects
Search...

Event Timeline

Xaosflux triaged this task as High priority.Jan 29 2021, 7:14 PM
Xaosflux created this task.

See report with tests on enwiki.

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1003596331#Unable_to_set_Pending_Changes

Xaosflux renamed this task from administrators are intermitintly unable to set pending changes on enwiki to administrators are intermittently unable to configure pending changes on enwiki.Jan 29 2021, 7:16 PM
Xaosflux edited projects, added MediaWiki-extensions-FlaggedRevs; removed User-DannyS712, MediaWiki-User-management.
JJMC89 added a project: Regression.Jan 29 2021, 7:17 PM
JJMC89 subscribed.

Possibly related to T273296: Some administrators can no longer add/remove users from the autochecked/editor user groups

Aklapper removed a project: Release-Engineering-Team.Jan 29 2021, 7:55 PM
Kyykaarme subscribed.Jan 29 2021, 8:01 PM

In the Finnish Wikipedia a user who is in the reviewer user group with "stablesettings" right reported last night that they lost the ability to change the FlaggedRevs settings in articles. No admin has reported the same problem, but I don't know how many have tried it. The user said that they don't see the option anymore in the drop-down menu at the top of the article.

Asartea subscribed.Jan 29 2021, 8:11 PM
Xaosflux renamed this task from administrators are intermittently unable to configure pending changes on enwiki to intermittently users with access are unable to configure pending changes.Jan 29 2021, 8:19 PM
Xaosflux renamed this task from intermittently users with access are unable to configure pending changes to some users with access are unable to configure pending changes.
Stryn subscribed.Jan 29 2021, 8:21 PM
taavi subscribed.Jan 29 2021, 8:28 PM
gerritbot added a comment.Jan 29 2021, 8:32 PM

Change 660006 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@master] Revert "Remove usages and hard deprecate User::changeable(By)Group"

https://gerrit.wikimedia.org/r/660006

gerritbot added a project: Patch-For-Review.Jan 29 2021, 8:32 PM

Change 660007 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Remove usages and hard deprecate User::changeable(By)Group"

https://gerrit.wikimedia.org/r/660007

Reedy added a parent task: T273296: Some administrators can no longer add/remove users from the autochecked/editor user groups.Jan 29 2021, 8:48 PM
dancy added a parent task: T271342: 1.36.0-wmf.28 deployment blockers.Jan 29 2021, 8:49 PM
dancy added a parent task: T271343: 1.36.0-wmf.29 deployment blockers.
4shadoww subscribed.Jan 29 2021, 8:51 PM
RhinosF1 subscribed.Jan 29 2021, 8:59 PM
gerritbot added a comment.Jan 29 2021, 9:39 PM

Change 660007 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Remove usages and hard deprecate User::changeable(By)Group"

https://gerrit.wikimedia.org/r/660007

Reedy updated the task description. (Show Details)Jan 29 2021, 9:48 PM
taavi raised the priority of this task from High to Unbreak Now!.Jan 29 2021, 10:43 PM
Reedy lowered the priority of this task from Unbreak Now! to High.Jan 29 2021, 10:47 PM
Reedy added a project: Platform Engineering.
• Pchelolo edited projects, added Platform Team Workboards (MW Expedition); removed Platform Engineering.Jan 30 2021, 2:24 AM
gerritbot added a comment.Jan 30 2021, 3:50 PM

Change 660006 merged by jenkins-bot:
[mediawiki/core@master] Revert "Remove usages and hard deprecate User::changeable(By)Group"

https://gerrit.wikimedia.org/r/660006

Maintenance_bot removed a project: Patch-For-Review.Jan 30 2021, 4:10 PM
gerritbot added a comment.Jan 31 2021, 11:18 PM

Change 660532 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group""

https://gerrit.wikimedia.org/r/660532

gerritbot added a project: Patch-For-Review.Jan 31 2021, 11:18 PM

Change 660532 abandoned by Urbanecm:
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group""

Reason:

https://gerrit.wikimedia.org/r/660532

gerritbot added a comment.Jan 31 2021, 11:22 PM

Change 660532 restored by Urbanecm:
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group""

https://gerrit.wikimedia.org/r/660532

gerritbot added a comment.Jan 31 2021, 11:22 PM

Change 660532 abandoned by Urbanecm:
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group""

Reason:

https://gerrit.wikimedia.org/r/660532

gerritbot added a comment.Jan 31 2021, 11:24 PM

Change 660533 had a related patch set uploaded (by Urbanecm; owner: Urbanecm):
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group"""

https://gerrit.wikimedia.org/r/660533

gerritbot added a comment.Feb 1 2021, 10:26 AM

Change 660533 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.28] Revert "Revert "Revert "Remove usages and hard deprecate User::changeable(By)Group"""

https://gerrit.wikimedia.org/r/660533

Stashbot mentioned this in T273296: Some administrators can no longer add/remove users from the autochecked/editor user groups.Feb 1 2021, 10:39 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-01T10:39:40Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.28/includes/user//User.php: Fixing T273317 T273296 (duration: 00m 58s)

Stashbot added a comment.Feb 1 2021, 10:41 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-01T10:41:04Z] <urbanecm@deploy1001> sync-file aborted: Fixing T273317 T273296 (duration: 00m 12s)

Stashbot added a comment.Feb 1 2021, 10:42 AM

Mentioned in SAL (#wikimedia-operations) [2021-02-01T10:42:14Z] <urbanecm@deploy1001> Synchronized php-1.36.0-wmf.28/includes/: Fixing T273317 T273296 (duration: 01m 01s)

taavi removed parent tasks: T271343: 1.36.0-wmf.29 deployment blockers, T271342: 1.36.0-wmf.28 deployment blockers.Feb 1 2021, 1:40 PM
• Pchelolo mentioned this in T273510: Convert AuthManager to Authority.Feb 1 2021, 6:11 PM
• Pchelolo mentioned this in T273511: Convert CentralAuthUtilityService to Authority instead of PermissionManager.
• Pchelolo closed this task as Resolved.Feb 1 2021, 6:19 PM
• Pchelolo claimed this task.
• Pchelolo added subscribers: Urbanecm, • Pchelolo.

Ive created followup tasks T273510 and T273511 that would allow us to fix the issue properly and unrevert it. According to @Urbanecm in T273296#6791634 this is not resolved.

taavi mentioned this in T275017: Reviewers can't stabilize pages on fiwiki.Feb 17 2021, 12:26 PM
Xaosflux added a comment.Feb 19 2021, 7:19 PM

admins are reporting this problem again:

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1007745186#Pending_Changes_again

Aklapper mentioned this in T275288: I am an extended confirmed user but my edits are no longer automatically accepted by the pending changes protection tool.Feb 20 2021, 9:06 PM
Aklapper merged a task: T275288: I am an extended confirmed user but my edits are no longer automatically accepted by the pending changes protection tool.
Aklapper added subscribers: Jontel, CaptainEek, suffusion_of_yellow, Caius_G.
suffusion_of_yellow unsubscribed.Feb 20 2021, 9:08 PM
Urbanecm reopened this task as Open.Feb 20 2021, 9:21 PM
Urbanecm added a comment.Feb 20 2021, 11:51 PM
In T273317#6844326, @Xaosflux wrote:

admins are reporting this problem again:

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1007745186#Pending_Changes_again

(follow-up to T275017#6846089) I just checked with an enwiki admin, and they managed to configure pending changes. Is this still an issue?

Xaosflux added a comment.Feb 20 2021, 11:52 PM

Not sure if same problem, or related problem - from T275017 -
*Edits made by some editors with autoaccept access are not being autoaccepted

Xaosflux added a comment.Feb 20 2021, 11:54 PM
In T273317#6846098, @Urbanecm wrote:
In T273317#6844326, @Xaosflux wrote:

admins are reporting this problem again:

https://en.wikipedia.org/w/index.php?title=Wikipedia:Village_pump_(technical)&oldid=1007745186#Pending_Changes_again

(follow-up to T275017#6846089) I just checked with an enwiki admin, and they managed to configure pending changes. Is this still an issue?

The problem wasn't presenting as "no admin" can do this - it was "some admins" can't do this - and it seemed to for some reason be sticky to the ones that couldn't. Did you get confirmation from someone that recently had the failure?

Urbanecm added a comment.Feb 20 2021, 11:57 PM
In T273317#6846105, @Xaosflux wrote:

Not sure if same problem, or related problem - from T275017 -
*Edits made by some editors with autoaccept access are not being autoaccepted

Could you fill a new task, as it appears to be a separate issue (at least it has separate symptomps)? Please also include some diffs to (recent) edits that were not autoaccepted, while they should be.

In T273317#6846109, @Xaosflux wrote:

[...]
The problem wasn't presenting as "no admin" can do this - it was "some admins" can't do this - and it seemed to for some reason be sticky to the ones that couldn't. Did you get confirmation from someone that recently had the failure?

No. I added a comment to the VPT post you linked, there doesn't seem to be any reply so far. A handful of admins managed to change PC recently through, see https://en.wikipedia.org/wiki/Special:Log/stable.

Xaosflux added a comment.Feb 21 2021, 12:06 AM

OK there seem to be 2 issues here:

  1. Some edits by some users with autoaccept access are not being autoaccepted
  2. Some users (admins) with access to configure pending changes are not able to configure pending changes

This is certainly trickier in that it is not always failing for everyone. When the admins reporting the problem had it occur, other admins were still able to do it.

Jontel added a comment.Feb 21 2021, 9:02 AM

I am an extended confirmed user editor on wikipedia. On Michael Rosen, which is pending changes protected, my 8 Feb edit https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1005571365&oldid=1005008162 was automatically accepted but those of 19 Feb were not e.g. (the first one) https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1007735566&oldid=1007730996. The edit history shows the issue more clearly: https://en.wikipedia.org/w/index.php?title=Michael_Rosen&action=history I have not had this problem before.
The issue is the same for all pending changes protection articles which I have subsequently edited e.g.
https://en.wikipedia.org/w/index.php?title=2008_Mumbai_attacks&action=history

Urbanecm added a comment.Feb 21 2021, 4:01 PM
In T273317#6846254, @Jontel wrote:

I am an extended confirmed user editor on wikipedia. On Michael Rosen, which is pending changes protected, my 8 Feb edit https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1005571365&oldid=1005008162 was automatically accepted but those of 19 Feb were not e.g. (the first one) https://en.wikipedia.org/w/index.php?title=Michael_Rosen&type=revision&diff=1007735566&oldid=1007730996. The edit history shows the issue more clearly: https://en.wikipedia.org/w/index.php?title=Michael_Rosen&action=history I have not had this problem before.
The issue is the same for all pending changes protection articles which I have subsequently edited e.g.
https://en.wikipedia.org/w/index.php?title=2008_Mumbai_attacks&action=history

This sounds to be a different case than (partial?) unability to configure pending changes. Can you create another task for that, please?

Jontel added a comment.Feb 21 2021, 6:42 PM

OK, I have created another task for that.

https://phabricator.wikimedia.org/T275322

Urbanecm removed a project: Patch-For-Review.Feb 21 2021, 9:11 PM
JJMC89 unsubscribed.Feb 21 2021, 9:23 PM
MBH mentioned this in T275337: Rename "autoeditor" user group in ruwiki to "autoreview".Feb 22 2021, 2:23 AM
daniel moved this task from Unsorted pile to Waiting for Review on the Platform Team Workboards (MW Expedition) board.Feb 23 2021, 6:44 PM
daniel moved this task from Waiting for Review to Blocked on the Platform Team Workboards (MW Expedition) board.
gerritbot added a comment.Feb 24 2021, 9:52 AM

Change 666587 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/FlaggedRevs@master] Run setup from MediaWikiServices hook.

https://gerrit.wikimedia.org/r/666587

gerritbot added a project: Patch-For-Review.Feb 24 2021, 9:52 AM
• Pchelolo added a comment.Mar 5 2021, 1:20 AM

Can someone retest this please? I think that some of the recent changes in wmf.33 might have fixed the problem.

Jontel added a comment.Mar 5 2021, 8:18 AM

In response to Pchelolo, I just tried to edit [[Bobbi Billard]] and my edit was not automatically accepted.

Asartea added a comment.Mar 5 2021, 8:23 AM
In T273317#6885147, @Jontel wrote:

In response to Pchelolo, I just tried to edit [[Bobbi Billard]] and my edit was not automatically accepted.

Yup it didn't do it when it should. I have now manually accepted it which did work for me.

Courtesy link: https://en.wikipedia.org/w/index.php?title=Bobbi_Billard&action=history

Tgr added a comment.Mar 5 2021, 3:19 PM
In T273317#6884958, @Pchelolo wrote:

Can someone retest this please? I think that some of the recent changes in wmf.33 might have fixed the problem.

Which changes do you have in mind?

I can see how https://gerrit.wikimedia.org/r/c/mediawiki/extensions/FlaggedRevs/+/666587 could fix this, but that hasn't been merged yet.

• Pchelolo added a comment.Mar 5 2021, 3:21 PM

T273510 and T273511 might have moved PermissionManager instantiation late enough to avoid this problem and get back to status quo - very unstable and can break at any moment, but working.

Wugapodes moved this task from Backlog to Under review on the MediaWiki-extensions-FlaggedRevs board.Mar 16 2021, 9:13 PM
stwalkerster subscribed.Mar 17 2021, 11:47 PM
gerritbot added a comment.Apr 15 2021, 10:09 PM

Change 666587 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Run setup from MediaWikiServices hook.

https://gerrit.wikimedia.org/r/666587

Tgr mentioned this in T275334: Changing user groups from $wgExtensionFunctions no longer works reliably.Apr 26 2021, 10:20 AM
Tgr added a comment.May 5 2021, 7:51 PM

Presumably this was fixed by the changes indicated in T273317#6886636? I can't reproduce it and I'm sure if the pending protection interface were broken completely, as the task description states, we would have heard a lot more about it in the three months since opening the task.

• Pchelolo closed this task as Resolved.May 25 2021, 1:47 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits