Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: 1
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	thcipriani
	Jun 8 2023, 4:00 PM

Description

Error

service.version: 1.41.0-wmf.12
trace.id: a16d47c1-98f8-44fc-96ab-d636e04e6a47
Find trace.id in Logstash

labels.normalized_message

[{reqId}] {exception_url}   Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: 1

error.stack_trace

from /srv/mediawiki/php-1.41.0-wmf.12/vendor/wikimedia/assert/src/Assert.php(49)
#0 /srv/mediawiki/php-1.41.0-wmf.12/includes/title/Title.php(4128): Wikimedia\Assert\Assert::precondition(boolean, string)
#1 /srv/mediawiki/php-1.41.0-wmf.12/extensions/DiscussionTools/includes/SpecialDiscussionToolsDebug.php(82): MediaWiki\Title\Title->toPageRecord()
#2 /srv/mediawiki/php-1.41.0-wmf.12/includes/htmlform/HTMLForm.php(746): MediaWiki\Extension\DiscussionTools\SpecialDiscussionToolsDebug->onSubmit(array, OOUIHTMLForm)
#3 /srv/mediawiki/php-1.41.0-wmf.12/includes/htmlform/HTMLForm.php(626): HTMLForm->trySubmit()
#4 /srv/mediawiki/php-1.41.0-wmf.12/includes/htmlform/HTMLForm.php(642): HTMLForm->tryAuthorizedSubmit()
#5 /srv/mediawiki/php-1.41.0-wmf.12/includes/specialpage/FormSpecialPage.php(224): HTMLForm->show()
#6 /srv/mediawiki/php-1.41.0-wmf.12/includes/specialpage/SpecialPage.php(701): FormSpecialPage->execute(NULL)
#7 /srv/mediawiki/php-1.41.0-wmf.12/includes/specialpage/SpecialPageFactory.php(1554): SpecialPage->run(NULL)
#8 /srv/mediawiki/php-1.41.0-wmf.12/includes/MediaWiki.php(328): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#9 /srv/mediawiki/php-1.41.0-wmf.12/includes/MediaWiki.php(925): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.41.0-wmf.12/includes/MediaWiki.php(579): MediaWiki->main()
#11 /srv/mediawiki/php-1.41.0-wmf.12/index.php(50): MediaWiki->run()
#12 /srv/mediawiki/php-1.41.0-wmf.12/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

Notes

Reproducible with a GET request on many wikis

Details

Request URL: https://foundation.wikimedia.org/wiki/Special:DiscussionToolsDebug?pagetitle=*

	Subject	Repo	Branch	Lines +/-
	DiscussionToolsDebug: check whether the given page exists	mediawiki/extensions/DiscussionTools	master	+1 -0

Customize query in gerrit

Event Timeline

thcipriani created this task.Jun 8 2023, 4:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJun 8 2023, 4:00 PM

thcipriani moved this task from Untriaged to Jun 2023 on the Wikimedia-production-error board.Jun 8 2023, 4:00 PM

ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.Jun 15 2023, 3:19 PM

Looks like Special:DiscussionToolsDebug doesn't check whether the page title given to it exists. Should be a simple fix. The bug has minimal user impact (if you type in such a title on the page, you get an ugly error message instead of a pretty one – that's all).

Hi,
Could you please clarify, what message should be displayed, if the page title doesn't exist?
Should it be:
"nopagetitle": "No such target page"
"nopagetext": "The target page you have specified does not exist."
?

Thanks,
Rajashree

@RajashreeTalukdar Hi, I think an error message will be generated automatically if you add 'exists' => true, to the definition of the form, here: https://gerrit.wikimedia.org/g/mediawiki/extensions/DiscussionTools/+/3583d7367a64b8f861efaa819e3fd2bca469bc09/includes/SpecialDiscussionToolsDebug.php#46

Change 952480 had a related patch set uploaded (by RajashreeTalukdar; author: RajashreeTalukdar):

[mediawiki/extensions/DiscussionTools@master] DiscussionToolsDebug modified to check whether the page title given, exists or not

https://gerrit.wikimedia.org/r/952480

gerritbot added a project: Patch-For-Review.Aug 25 2023, 5:38 PM

Change 952480 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] DiscussionToolsDebug: check whether the given page exists

https://gerrit.wikimedia.org/r/952480

matmarex closed this task as Resolved.Aug 29 2023, 7:36 PM

matmarex assigned this task to RajashreeTalukdar.

Maintenance_bot removed a project: Patch-For-Review.Aug 29 2023, 8:10 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 6:01 AM

Wikimedia\Assert\PreconditionException: Precondition failed: This Title instance does not represent an existing page: 1Closed, ResolvedPublicPRODUCTION ERRORActions