Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Maniphest T340733

DefaultView page-wide: Error handling correctly on granular components
Closed, ResolvedPublicBUG REPORT

Description

Description

We have implemented a centralized error system where each error can be:

  • either marked with the zobject row ID to allow the components to grab any errors that have been detected, or
  • a generic error shown page-wide, which should be shown in the Publish component as part of the publishing flow

Observed behavior:

  • Errors are currently not being shown properly or being shared among components.
  • Errors from failed implementation are being shown in the About widget

Screen Shot 2023-06-21 at 8.40.42 PM.png (1×2 px, 317 KB)

Screen Shot 2023-06-21 at 8.39.09 PM.png (1×1 px, 247 KB)

Expected behavior (Acceptance criteria):

We should

  • review all the new Default View components and make sure that all getError methods are being called with the right ids
  • review handling of general page-wide errors and make sure that the are reported in the Publish Dialog
  • review the widget About and make sure that only relevant errors are being shown in its fields

Completion checklist

Event Timeline

Change 938253 had a related patch set uploaded (by Genoveva Galarza; author: Genoveva Galarza):

[mediawiki/extensions/WikiLambda@master] [WIP] Fix error handling in the Vue app

https://gerrit.wikimedia.org/r/938253

Change 938253 merged by Jforrester:

[mediawiki/extensions/WikiLambda@master] Fix error handling in the Vue app

https://gerrit.wikimedia.org/r/938253

DVrandecic subscribed.

I tried some of the error conditions, and everything so far worked as expected. That's a large patch! Thanks!