Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Maniphest T341740

GrowthExperiments help icon shouldn't remove limited width toggle on Vector
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

What happens?:
The help icon shows, but the limited width icon does not.

Screenshot 2023-07-12 at 2.56.23 PM.png (1×2 px, 521 KB)

What should have happened instead?:
Both icons should show

Screenshot 2023-07-12 at 2.56.37 PM.png (1×2 px, 231 KB)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):
In T336431 we added an API to provide an extensible menu in the bottom right of the screen. GrowthExperiments should make use of that!

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 937536 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/skins/Vector@master] Show limited width icon alongside help button

https://gerrit.wikimedia.org/r/937536

Change 937537 had a related patch set uploaded (by Jdlrobson; author: Jdlrobson):

[mediawiki/extensions/GrowthExperiments@master] GrowthExperiments help icon shouldn't remove limited width toggle on Vector

https://gerrit.wikimedia.org/r/937537

Both patches in Vector have +1 from Readers. Seems this is okay to go now?

Change 937537 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] GrowthExperiments help icon shouldn't remove limited width toggle on Vector

https://gerrit.wikimedia.org/r/937537

Change 937536 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Show limited width icon alongside help button

https://gerrit.wikimedia.org/r/937536

Requested CR completed.

Although it seems this is technically a bug report? Moving to QA for Growth review.

Urbanecm_WMF renamed this task from Code review request: GrowthExperiments help icon shouldn't remove limited width toggle on Vector to GrowthExperiments help icon shouldn't remove limited width toggle on Vector.Jul 24 2023, 9:14 PM
Etonkovidova subscribed.

Checked on eswiki wmf.19 - the limited width toggle is present along with the Help icon:

Screen Shot 2023-07-29 at 4.59.17 PM.png (1×2 px, 280 KB)
Screen Shot 2023-07-29 at 5.01.18 PM.png (1×1 px, 188 KB)