Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Maniphest T342490

Unable to switch to Visual Editor with changes on mobile
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  • Edit a new Wikipedia page (example)
  • Add any text on the page
  • Click the pencil icon at the top and then "Visual editing"

What happens?:
Nothing happens.

What should have happened instead?:
The user should be able to continue editing using the Visual Editor. This worked before.

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Event Timeline

Esanders renamed this task from Unable to switch to Visual Editor on mobile version to Unable to switch to Visual Editor with changes on mobile .Jul 22 2023, 10:39 PM
Esanders triaged this task as High priority.
Esanders added a project: Regression.
Esanders added a subscriber: matmarex.

TypeError: mw.libs.ve.SwitchConfirmDialog is not a constructor

I think this is because we merged the VE patch removing the switcher before the train cut, but no the MobileFrontend patch (https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/937154).

Everything appears to be working on beta: https://en.m.wikipedia.beta.wmflabs.org/wiki/Fox#/editor/0

It's my fault from T339871, at first I missed that the task had a MobileFrontend part, and when I realized that, I also missed that the VisualEditor part depends on it.

To resolve it, it'd be easiest to backport https://gerrit.wikimedia.org/r/c/mediawiki/extensions/MobileFrontend/+/937154. Does anyone want to do it? I'm supposed to be on vacation D:

Now resolved by the regular weekly deployment train.

ppelberg claimed this task.