In https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/965928 @Tgr noticed and documented that we support displaying the page Special:CentralLogin/status, but nothing in our code refers to it.
We should find out how that came to be, verify that it's not needed, and then remove it.
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove unused Special:CentralLogin/status | mediawiki/extensions/CentralAuth | master | +5 -33 |
It was added in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/59211 (first implementation of central login).
In that version, the user would sometimes be redirected to Special:CentralLogin/status (when the user was already logged in): https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralAuth/+/f8e4226189bdc59d5e6503b5ccbf6df5e9dadaa8/specials/SpecialCentralLogin.php#59
…and sometimes to Special:CentralLogin (when switching between HTTP and HTTPS protocols): https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/CentralAuth/+/f8e4226189bdc59d5e6503b5ccbf6df5e9dadaa8/specials/SpecialCentralLogin.php#180
Those scenarios were removed in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/72657 and https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/267948.
Special:CentralLogin currently isn't completely useless – if the user visits it, it attempts edge login. I don't really see why we would want to support doing this, when it already happens as part of the normal login process (other than as a workaround for other login bugs, I guess). It doesn't seem to be documented anywhere that you can use it to do that.
I think we should remove it, and see if anyone complains.
Change 966263 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):
[mediawiki/extensions/CentralAuth@master] Remove unused Special:CentralLogin/status
It was slightly useful when we added a new top-level domain (wikifunctions.org) to give existingly-logged-in users the right cookie, though given that that was the first for 11 years…
We have a better way to do that now, though – since T326281, if you're centrally logged in, you can just click "Log in" (go to https://www.wikifunctions.org/wiki/Special:UserLogin) and you'll find yourself logged in there too. Going to a secret special page on another wiki in order to become logged in on Wikifunctions seems much worse.
Also when edge login is working, autologin should also be working, so people can just visit any page on the new wiki, reload, and be logged in.
Change 966263 merged by jenkins-bot:
[mediawiki/extensions/CentralAuth@master] Remove unused Special:CentralLogin/status