Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Maniphest T350614

/wiki/Special:ChangeEmail TypeError: Argument 4 passed to MediaWiki\Mail\Emailer::send() must be of the type string, array given
Closed, ResolvedPublicBUG REPORT

Description

Steps to replicate the issue (include links if applicable):

  1. Create a new account or log into an account
  2. Attempt to add an email address to an account using Special:ChangeEmail

What happens?:
A server error appears with the following stack trace:

trace
/wiki/Special:ChangeEmail TypeError: Argument 4 passed to MediaWiki\Mail\Emailer::send() must be of the type string, array given, called in /srv/mediawiki/php-master/includes/user/User.php on line 3017

Backtrace:

from /srv/mediawiki/php-master/includes/mail/Emailer.php(43)
#0 /srv/mediawiki/php-master/includes/user/User.php(3017): MediaWiki\Mail\Emailer->send(array, MailAddress, string, array, NULL, array)
#1 /srv/mediawiki/php-master/includes/user/User.php(2984): MediaWiki\User\User->sendMail(string, array, NULL, NULL)
#2 /srv/mediawiki/php-master/includes/user/User.php(1994): MediaWiki\User\User->sendConfirmationMail(string)
#3 /srv/mediawiki/php-master/includes/specials/SpecialChangeEmail.php(196): MediaWiki\User\User->setEmailWithConfirmation(string)
#4 /srv/mediawiki/php-master/includes/specials/SpecialChangeEmail.php(139): MediaWiki\Specials\SpecialChangeEmail->attemptChange(MediaWiki\User\User, string)
#5 [internal function]: MediaWiki\Specials\SpecialChangeEmail->onSubmit(array, OOUIHTMLForm)
#6 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(751): call_user_func(array, array, OOUIHTMLForm)
#7 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(631): HTMLForm->trySubmit()
#8 /srv/mediawiki/php-master/includes/htmlform/HTMLForm.php(647): HTMLForm->tryAuthorizedSubmit()
#9 /srv/mediawiki/php-master/includes/specialpage/FormSpecialPage.php(231): HTMLForm->show()
#10 /srv/mediawiki/php-master/includes/specials/SpecialChangeEmail.php(77): MediaWiki\SpecialPage\FormSpecialPage->execute(NULL)
#11 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(727): MediaWiki\Specials\SpecialChangeEmail->execute(NULL)
#12 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1629): MediaWiki\SpecialPage\SpecialPage->run(NULL)
#13 /srv/mediawiki/php-master/includes/MediaWiki.php(357): MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, RequestContext)
#14 /srv/mediawiki/php-master/includes/MediaWiki.php(960): MediaWiki->performRequest()
#15 /srv/mediawiki/php-master/includes/MediaWiki.php(613): MediaWiki->main()
#16 /srv/mediawiki/php-master/index.php(50): MediaWiki->run()
#17 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#18 /srv/mediawiki/w/index.php(3): require(string)
#19 {main}

Software version (skip for WMF-hosted wikis like Wikipedia):
Master branch of core

Other information (browser name/version, screenshots, etc.):
Caused by 012a4a93ff5ecba3b88f3e9e70821b606d97a4ae

Event Timeline

Dreamy_Jazz triaged this task as Unbreak Now! priority.Nov 6 2023, 6:24 PM

UBN as a train blocker - prevents a user from adding or changing their email address on an account.

Dreamy_Jazz added a subscriber: Ladsgroup.

Adding @Ladsgroup as assignee per IRC (they said they would sort this before it hit production).

Change 972012 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/core@master] User: Make the ::sendMail split $body before passing to IEmailer

https://gerrit.wikimedia.org/r/972012

Change 972012 merged by jenkins-bot:

[mediawiki/core@master] User: Make the ::sendMail split $body before passing to IEmailer

https://gerrit.wikimedia.org/r/972012

Jdforrester-WMF subscribed.

FWICT this is Resolved.