Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Maniphest T362706

Permit displaying the login / signup page in a popup or iframe
Closed, ResolvedPublic

Description

One of the building blocks for T348388: Use central login wiki for login (SUL3) is going to be the ability to show the login and/or signup page in a popup window (or an iframe; from the POV of the embedded/popped-up page, it does not make much difference).

This involves a number of changes:

  • Add a flag to LoginSignupSpecialPage which displays the page without any skin (probably by using ApiSkin), and without most of the extra information that's normally shown on the initial login/signup page but not subsequent steps (e.g. benefits block; but we do want to keep the language chooser and login/signup switch, at least).
  • Use a query parameter to set the flag, and make sure it is sticky during the auth process, preferably including when a remote authentication provider is used. We could go with the OIDC vocabulary (display=popup).

We'll probably want to refine how anti-framing is handled (e.g. with CSP: frame-ancestors) but we can leave that for when we have a clearer plan for cookie handling.

Related Objects

Event Timeline

Change #1025874 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/core@master] LoginSignupSpecialPage: Support &display=popup

https://gerrit.wikimedia.org/r/1025874

A quick review of known use cases for this:

There was also a related discussion in T318142: Account creation + Growth tools: Improve UX for desktop VisualEditor but with no clear preference between popup / modal / redirect.

There might be a similar use case in the future related to temp users who need to be created dynamically on certain actions - this can be done in the background for baseline login, but not necessarily for central login. (See T355280: Try to connect to central session before temp user creation and T334623: How do we log unsuccessful first edits for temporary users?.)

(Note the title of this task says "popup" but the implementation is agnostic about whether the login/signup page will be shown in a popup or an iframe within a modal dialog; it's really just about showing a minimal version of the page that's not encumbered skin parts etc.)

Change #1025874 merged by jenkins-bot:

[mediawiki/core@master] LoginSignupSpecialPage: Support &display=popup

https://gerrit.wikimedia.org/r/1025874

matmarex renamed this task from Display the login / signup page in a popup to Permit displaying the login / signup page in a popup or iframe.Tue, Jun 18, 7:05 PM