Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Create Task
Maniphest T370874

Ref search dialog numbering is wrong when subrefs are present
Closed, ResolvedPublic
Actions

Description

We need to switch the numbering in this dialog to use the new source of truth coming from MWDocumentReferences. Otherwise, [1.1] will be rendered as [2] and so on, and any attempt to search or match by number will be incorrect.

Also make sure that the number is available in the fulltext search index.

Details

SubjectRepoBranchLines +/-
Refactor: raw index numbersmediawiki/extensions/Citemaster+153 -86
[WIP] Handle orphaned subrefsmediawiki/extensions/Citemaster+89 -79
[WIP] Refactor: Get rid of getGroupRefsByParentsmediawiki/extensions/Citemaster+35 -85
Rename function to getIndexLabel to clarify that it's presentationmediawiki/extensions/Citemaster+11 -11
Helper function getAllGroupNamesmediawiki/extensions/Citemaster+9 -5
[WIP] Push numbering into ref nodesmediawiki/extensions/Citemaster+73 -87
References always deal with original documentmediawiki/extensions/Citemaster+7 -3
Switch reuse dialog to use shared numbering mechanismmediawiki/extensions/Citemaster+56 -59
Customize query in gerrit

Event Timeline

awight created this task.Jul 24 2024, 1:17 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJul 24 2024, 1:17 PM
awight moved this task from Incoming to In progress on the WMDE-References-FocusArea board.Jul 24 2024, 3:12 PM
awight added a project: WMDE-TechWish-Sprint-2024-07-24.
gerritbot added a comment.Jul 24 2024, 3:14 PM

Change #1056526 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Switch reuse dialog to use shared numbering mechanism

https://gerrit.wikimedia.org/r/1056526

gerritbot added a project: Patch-For-Review.Jul 24 2024, 3:14 PM
awight moved this task from Sprint Backlog to Tech Review on the WMDE-TechWish-Sprint-2024-07-24 board.Jul 24 2024, 3:14 PM
gerritbot added a comment.Jul 26 2024, 10:06 AM

Change #1056526 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Switch reuse dialog to use shared numbering mechanism

https://gerrit.wikimedia.org/r/1056526

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2024, 10:30 AM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 26 2024, 11:00 AM
gerritbot added a comment.Jul 27 2024, 10:55 PM

Change #1057350 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] References always deal with original document

https://gerrit.wikimedia.org/r/1057350

gerritbot added a project: Patch-For-Review.Jul 27 2024, 10:55 PM

Change #1057351 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Helper function getAllGroupNames

https://gerrit.wikimedia.org/r/1057351

gerritbot added a comment.Jul 27 2024, 10:55 PM

Change #1057352 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Rename function to getIndexLabel to clarify that it's presentation

https://gerrit.wikimedia.org/r/1057352

gerritbot added a comment.Jul 27 2024, 10:55 PM

Change #1057353 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] Refactor: raw index numbers

https://gerrit.wikimedia.org/r/1057353

gerritbot added a comment.Jul 28 2024, 9:14 AM

Change #1057380 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Refactor: Get rid of getGroupRefsByParents

https://gerrit.wikimedia.org/r/1057380

gerritbot added a comment.Jul 28 2024, 9:14 AM

Change #1057381 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Push numbering into ref nodes

https://gerrit.wikimedia.org/r/1057381

gerritbot added a comment.Jul 29 2024, 9:29 PM

Change #1057350 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] References always deal with original document

https://gerrit.wikimedia.org/r/1057350

gerritbot added a comment.Jul 30 2024, 12:30 PM

Change #1057351 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Helper function getAllGroupNames

https://gerrit.wikimedia.org/r/1057351

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.17; 2024-08-06); removed MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Jul 30 2024, 1:00 PM
gerritbot added a comment.Thu, Aug 1, 6:33 AM

Change #1057352 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] Rename function to getIndexLabel to clarify that it's presentation

https://gerrit.wikimedia.org/r/1057352

gerritbot added a comment.Fri, Aug 2, 11:46 AM

Change #1059303 had a related patch set uploaded (by Awight; author: Awight):

[mediawiki/extensions/Cite@master] [WIP] Handle orphaned subrefs

https://gerrit.wikimedia.org/r/1059303

awight moved this task from Tech Review to Demo on the WMDE-TechWish-Sprint-2024-07-24 board.Mon, Aug 5, 11:44 AM
thiemowmde closed this task as Resolved.Tue, Aug 13, 9:17 AM
thiemowmde claimed this task.
gerritbot added a comment.Tue, Aug 20, 11:40 AM

Change #1057380 abandoned by Awight:

[mediawiki/extensions/Cite@master] [WIP] Refactor: Get rid of getGroupRefsByParents

Reason:

Doesn't work on its own. Squashed.

https://gerrit.wikimedia.org/r/1057380

gerritbot added a comment.Fri, Aug 30, 10:41 AM

Change #1059303 abandoned by Awight:

[mediawiki/extensions/Cite@master] [WIP] Handle orphaned subrefs

https://gerrit.wikimedia.org/r/1059303

gerritbot added a comment.Fri, Aug 30, 10:47 AM

Change #1057353 abandoned by Awight:

[mediawiki/extensions/Cite@master] Refactor: raw index numbers

https://gerrit.wikimedia.org/r/1057353

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits