Default to not performing sanity checks
Closed, ResolvedPublic8 Estimated Story Points
Actions

Assigned To

Authored By

	ori
	Jan 19 2015, 3:18 AM

Description

Seen during VE load. What in the name of all that is holy is going on here?

Details

	Subject	Repo	Branch	Lines +/-
	[WIP] Make sanity check synchronous	mediawiki/extensions/VisualEditor	master	+26 -68
	Remove the sanity check	mediawiki/extensions/VisualEditor	master	+4 -114

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Catrope	T87161 Default to not performing sanity checks
		Resolved		yuvipanda	T87215 Re-image osmium and repurpose into VE testing host

Event Timeline

ori created this task.Jan 19 2015, 3:18 AM

ori raised the priority of this task from to Needs Triage.

ori updated the task description. (Show Details)

ori added projects: VisualEditor-Performance, VisualEditor.

ori added subscribers: ori, Catrope, Krinkle.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptJan 19 2015, 3:18 AM

Notes from discussing this w/Roan:

The reason we call oo.copy as part of ve.init.mw.Target.startSanityCheck is that we can't perform a sanity-check once the user has started editing the page.
The idea was to stash a clean copy of the DOM and then sanity-check roundtripping against that.
Instead of doing that, it might be cheaper to just prevent the user from touching the DOM until it has been sanity-check. If we do that, then we don't need to stash a copy.

ori assigned this task to Catrope.Jan 20 2015, 7:16 PM

ori set Security to None.

Jdforrester-WMF triaged this task as High priority.Jan 20 2015, 7:18 PM

Jdforrester-WMF moved this task from To Triage to Bug Fixes on the VisualEditor board.Jan 20 2015, 8:09 PM

Jdforrester-WMF raised the priority of this task from High to Unbreak Now!.Jan 20 2015, 9:10 PM

Change 186100 had a related patch set uploaded (by Catrope):
[WIP] Make sanity check synchronous

https://gerrit.wikimedia.org/r/186100

Patch-For-Review

ori added a subtask: T87215: Re-image osmium and repurpose into VE testing host.Jan 21 2015, 2:06 AM

Krenair subscribed.Jan 21 2015, 2:08 AM

ori moved this task from Backlog to Doing on the VisualEditor-Performance board.Jan 23 2015, 7:48 AM

Jdforrester-WMF added a project: VisualEditor 2014/15 Q3 blockers.Jan 23 2015, 11:32 PM

Jdforrester-WMF edited a custom field.Jan 23 2015, 11:45 PM

yuvipanda closed subtask T87215: Re-image osmium and repurpose into VE testing host as Resolved.Jan 24 2015, 1:09 AM

Liuxinyu970226 subscribed.Feb 1 2015, 2:35 AM

Jdforrester-WMF edited a custom field.Feb 2 2015, 7:37 PM

Jdforrester-WMF moved this task from Nominated to Accepted on the VisualEditor 2014/15 Q3 blockers board.Feb 3 2015, 5:02 PM

• TrevorParscal edited a custom field.Feb 4 2015, 7:09 PM

• Elitre subscribed.Feb 11 2015, 8:40 PM

Jdforrester-WMF moved this task from Bug Fixes to Blocked on the VisualEditor board.Feb 16 2015, 6:50 PM

Per discussion with Roan and James on 17-Feb-2015, we are going to stop running the sanity check on every run. We'll keep the code for now, but we'll hide it behind a magic query parameter.

Change 191233 had a related patch set uploaded (by Catrope):
Remove the sanity check

https://gerrit.wikimedia.org/r/191233

Patch-For-Review

Change 191233 merged by jenkins-bot:
Remove the sanity check

https://gerrit.wikimedia.org/r/191233

Catrope mentioned this in rEVED237bb053d614: Remove the sanity check.Feb 18 2015, 1:38 AM

Jdforrester-WMF closed this task as Resolved.Feb 18 2015, 2:06 AM

Jdforrester-WMF edited projects, added WMF-deploy-2015-02-18_(1.25wmf18); removed Patch-For-Review.

Liuxinyu970226 unsubscribed.Feb 18 2015, 2:14 AM

Jdforrester-WMF moved this task from Accepted to Done on the VisualEditor 2014/15 Q3 blockers board.Feb 18 2015, 3:30 PM

ori moved this task from Doing to Done on the VisualEditor-Performance board.Feb 19 2015, 2:29 AM

Jdforrester-WMF moved this task from Blocked to FY 18-19 Q3/Q4 on the VisualEditor board.Feb 21 2015, 12:35 AM