Svoboda | Graniru | BBC Russia | Golosameriki | Facebook
BBC RussianHomePhabricator
Log In
Maniphest T87535

Chunked upload offset error should specify expected offset
Closed, ResolvedPublic

Description

Consider an unstable WiFi connection. Let's say the connection vanishes for 30s after one chunk has been uploaded but before the server did respond asking for the next chunk. The client won't know whether the server could process the previous chunk correctly. So the client might send the same chunk again. However, if the server processed sent chunk, it generates a invalid-chunk-offset error

{"servedby":"mw1133","error":{"code":"stashfailed","info":"Invalid chunk offset","*":"See https://commons.wikimedia.org/w/api.php for API usage"}}

That's nice. But it doesn't contain what the server expected. This information would be utterly helpful to clients.

Event Timeline

Rillke raised the priority of this task from to Needs Triage.
Rillke updated the task description. (Show Details)
Rillke subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot subscribed.

Change 190221 had a related patch set uploaded (by Rillke):
Chunked upload: Return expected offset on offset error

https://gerrit.wikimedia.org/r/190221

Patch-For-Review

Change 190221 merged by jenkins-bot:
Chunked upload: Return expected offset on offset error

https://gerrit.wikimedia.org/r/190221

Rillke claimed this task.

Verified in production.