"Clicking the image closes the download menu" browser test failing on IE
Closed, ResolvedPublic2 Estimated Story Points
Actions

Assigned To

Authored By

	• Gilles
	Feb 10 2015, 8:02 AM

Description

Could be a genuine bug.

Details

Subject	Repo	Branch	Lines +/-
Workaround for Safari web driver	mediawiki/extensions/MultimediaViewer	master	+6 -1
Click in the top-left corner of the image when trying to close the download dialog	mediawiki/extensions/MultimediaViewer	master	+13 -2
Wait for the download menu to appear before closing it	mediawiki/extensions/MultimediaViewer	master	+5 -0

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		• Gilles	T87831 Improve reliability of cucumber tests
		Resolved		• Gilles	T89087 "Clicking the image closes the download menu" browser test failing on IE

Event Timeline

• Gilles created this task.Feb 10 2015, 8:02 AM

• Gilles claimed this task.

• Gilles raised the priority of this task from to Medium.

• Gilles updated the task description. (Show Details)

• Gilles added a project: MediaViewer.

• Gilles subscribed.

Restricted Application added a project: Multimedia. · View Herald TranscriptFeb 10 2015, 8:02 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

• Gilles moved this task from Untriaged to Next up on the Multimedia board.Feb 11 2015, 1:05 PM

• Gilles added a parent task: T87831: Improve reliability of cucumber tests.Feb 11 2015, 7:15 PM

Change 190032 had a related patch set uploaded (by Gilles):
Wait for the download menu to appear before closing it

https://gerrit.wikimedia.org/r/190032

Patch-For-Review

• Gilles moved this task from Next up to Needs code review on the Multimedia board.Feb 11 2015, 7:29 PM

Change 190032 merged by jenkins-bot:
Wait for the download menu to appear before closing it

https://gerrit.wikimedia.org/r/190032

Tgr moved this task from Needs code review to Ready for testing on the Multimedia board.Feb 11 2015, 11:41 PM

• Gilles mentioned this in rEMMV8c37b7abb4cd: Wait for the download menu to appear before closing it.Feb 11 2015, 11:41 PM

This wasn't sufficient, the issue turns out to be that in IE the test will have the image click land on the download dialog, which means it won't close. Clicking in the top-left corner instead fixes the test.

Change 190430 had a related patch set uploaded (by Gilles):
Click in the top-left corner of the image when trying to close the download dialog

https://gerrit.wikimedia.org/r/190430

Patch-For-Review

• Gilles moved this task from Ready for testing to Needs code review on the Multimedia board.Feb 13 2015, 11:19 AM

MarkTraceur moved this task from Needs code review to Ready for testing on the Multimedia board.Feb 13 2015, 10:43 PM

Change 190430 merged by jenkins-bot:
Click in the top-left corner of the image when trying to close the download dialog

https://gerrit.wikimedia.org/r/190430

• Gilles mentioned this in rEMMV94ac32835d63: Click in the top-left corner of the image when trying to close the download….Feb 13 2015, 10:45 PM

Sadly it seems like Safari's web driver doesn't support the mouse move command: https://integration.wikimedia.org/ci/job/browsertests-MultimediaViewer-en.wikipedia.beta.wmflabs.org-os_x_10.9-safari-sauce/471/testReport/junit/%28root%29/Download%20menu/Clicking_the_image_closes_the_download_menu/

I guess I'll check if the function exists and use the old general click if it's not there.

• Gilles removed a project: Patch-For-Review.Feb 16 2015, 1:31 PM

• Gilles set Security to None.