WMDE Technical Wishes developer
User Details
- User Since
- Oct 12 2014, 9:02 PM (515 w, 4 d)
- Availability
- Available
- IRC Nick
- awight
- LDAP User
- Awight
- MediaWiki User
- Adamw [ Global Accounts ]
Yesterday
The extra item about the mobile view read mode doesn't quite fit into the task, but I wanted to add that it's been partially implemented now. Previous behavior was that the subref would be duplicated, and now it shows a spinner in place of the parent, which is consistent with how other missing refs are handled.
Sorry, I'm unsetting the priority because I actually see this as already blocking work. Feel free to set it back again if I missed some discussion about the topic.
Wed, Aug 28
You'll want to add getRefUsages.length + getSubrefs.length almost everywhere that we count reuses.
Tue, Aug 27
Mon, Aug 26
Fri, Aug 23
Evaluating the indentation patch:
- Looks much better, although we could continue to reduce indentation. Mobile still has ever slightly more margin than desktop, which we could continue to adjust in the next design iteration. It's nearly perfect now. Compare the following, ordered by decreasing margin :rabbit-hole:
Mobile read mode, unpatched:
Mobile read mode, patched:
Desktop read mode:
Mobile edit mode:
Desktop edit mode:
- Correctly has no effect on the edit-mode interface.
- We could make indentation responsive to screen size (reduced on small screen) in a later iteration.
- Breadcrumb regarding the root cause: default browser styles include padding on all <ol> elements, which is reset to zero by Vector but not by MinervaNeue. Our solution is great for this one use case, but maybe a similar fix should be applied to the skin.
Tech Wishes will start investigating the current status and effort.
Thu, Aug 22
I just discovered an interaction with orphaned subrefs. Please test the behavior, currently I'm seeing the subref duplicated as its own parent.
Wed, Aug 21
Tue, Aug 20
Mon, Aug 19
Thiemo has also found a special behavior which will be challenging to reimplement: simply adding a tracking category to all pages where a Cite error occurs might not be fully equivalent to the logic on some wikis, which conditionally adds special tracking categories depending on the type of error. In other words, some errors are being ignored.
Dropping this task because we already know the general answer: it's a huge issue because there are entire wikis such as English Wikipedia which recommend wrapping the references tag in a template for all articles, in the manual of style.
Wed, Aug 14
One of the possibilities we discussed is to *allow* the orphaning to happen, but to then show warnings about this condition, eg. in the reflist. The task title should be tweaked to reflect this.
Tue, Aug 13
A related issue we still need to look into: when using VE section editing on mobile, we need to continue to support subrefs whose parent comes from another section. We also need to be able to reuse refs from elsewhere in the document.
Mon, Aug 12
I showed some of these issues to a RTL editor and he was able to verify the brokenness. Angle brackets and slashes should not move. He would be interested in seeing CodeMirror enabled on his wiki—and the new CodeMirror actually fixes some of the bidi issues. The LTR text with footnotes should not appear in the current order, basically a ref should stay next to its statement.
Tue, Aug 6
I'm very interested in getting bug reports about this area of Cite at the moment since work is active, as you can see, and it's easy to make mistakes when there are such a huge number of combinations of customization being applied. Thank you for taking the time to open a task!
Mon, Aug 5
Noting here that Kartographer is already broken for wikis that use LanguageConverter, but I can't find a good reference in Phabricator at the moment. The issue as I remember it was that language codes used to cache map snapshot images are simplified and couldn't distinguish between eg. zh-Hans and zh-Hant (or between zh and zh-Hans for that matter).
Fri, Aug 2
Wed, Jul 31
Yes, thanks I'll make sure to send an update in this week's Tech News!
Jul 31 2024
@Quiddity Thanks for the nudge—I've been concerned about the lingering bug here, as I can see that there are more wikis affected than I expected, and the workaround hasn't been applied anywhere yet.