Thanks @Amdrel! I see what you mean about the spacing looking uneven but on balance I think it's fine, as we don't appear to have an alternative solution if we want to fix the grey background issue.

Mon, Sep 2, 3:36 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

Thu, Aug 29

Kgraessle moved T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.

Thu, Aug 29, 2:01 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

gerritbot added a project to T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked: Patch-For-Review.

Thu, Aug 29, 2:00 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

gerritbot added a comment to T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked.

Change #1068788 had a related patch set uploaded (by Kgraessle; author: Kgraessle):

[mediawiki/extensions/Thanks@master] Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked

https://gerrit.wikimedia.org/r/1068788

Thu, Aug 29, 2:00 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Mon, Aug 26

Kgraessle claimed T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked.

Mon, Aug 26, 6:03 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Kgraessle moved T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked from Ready (Maintenance) to In Progress on the Moderator-Tools-Team (Kanban) board.

Mon, Aug 26, 6:03 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Dreamy_Jazz moved T331012: "Show IP" button hover background overlaps full stop on Special:Thanks from Priority Backlog to Needs review on the Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)) board.

Mon, Aug 26, 10:23 AM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

JayCano set the point value for T331012: "Show IP" button hover background overlaps full stop on Special:Thanks to 1.

Mon, Aug 26, 10:22 AM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

kostajh added a project to T331012: "Show IP" button hover background overlaps full stop on Special:Thanks: Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)).

In T331012#10081970, @Amdrel wrote:

Thanks for the patch and notes, @Amdrel. Could you please post screenshots with the before/after showing the potential downside you noted, for @KColeman-WMF to review?

Sure thing!

Before:

After:

Mon, Aug 26, 9:59 AM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

Thu, Aug 22

Kgraessle placed T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked up for grabs.

Thu, Aug 22, 2:31 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Kgraessle moved T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked from In Progress to Ready (Maintenance) on the Moderator-Tools-Team (Kanban) board.

Thu, Aug 22, 2:30 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Wed, Aug 21

Kgraessle claimed T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked.

Wed, Aug 21, 6:35 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Amdrel added a comment to T331012: "Show IP" button hover background overlaps full stop on Special:Thanks.

Thanks for the patch and notes, @Amdrel. Could you please post screenshots with the before/after showing the potential downside you noted, for @KColeman-WMF to review?

Wed, Aug 21, 3:45 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

kostajh updated subscribers of T331012: "Show IP" button hover background overlaps full stop on Special:Thanks.

In T331012#10079794, @Amdrel wrote:

I couldn't reproduce the issue with the provided steps, presumably because the styling of the temporary user name has changed since the ticket was opened. However, I was able to reproduce a very similar issue on Special:RecentChanges where semicolons following the "Show IP" button overlapped. I made a patch that removes the negative margin from the "Show IP" button to correct this. One downside I have noticed is that the spacing between the button and the semicolon looks uneven when not hovered on.

Wed, Aug 21, 7:55 AM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

Tue, Aug 20

Amdrel claimed T331012: "Show IP" button hover background overlaps full stop on Special:Thanks.

Tue, Aug 20, 11:17 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

Amdrel added a comment to T331012: "Show IP" button hover background overlaps full stop on Special:Thanks.

I couldn't reproduce the issue with the provided steps, presumably because the styling of the temporary user name has changed since the ticket was opened. However, I was able to reproduce a very similar issue on Special:RecentChanges where semicolons following the "Show IP" button overlapped. I made a patch that removes the negative margin from the "Show IP" button to correct this. One downside I have noticed is that the spacing between the button and the semicolon looks uneven when not hovered on.

Tue, Aug 20, 11:16 PM · MW-1.43-notes (1.43.0-wmf.21; 2024-09-03), Trust and Safety Product Sprint (Sprint Theremin (Aug 26 - Sept. 6)), Trust and Safety Product Team, IP-Masking-Growth-Team, Thanks, CheckUser, Temporary accounts, Growth-Team

gerritbot added a project to T331012: "Show IP" button hover background overlaps full stop on Special:Thanks: Patch-For-Review.

gerritbot added a comment to T331012: "Show IP" button hover background overlaps full stop on Special:Thanks.

Change #1064131 had a related patch set uploaded (by Amdrel; author: Amdrel):

[mediawiki/extensions/CheckUser@master] Correct overlap of "Show IP" button

https://gerrit.wikimedia.org/r/1064131

Samwalton9-WMF triaged T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked as Medium priority.

Tue, Aug 20, 4:26 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Samwalton9-WMF moved T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked from Ready to Ready (Maintenance) on the Moderator-Tools-Team (Kanban) board.

Tue, Aug 20, 4:24 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Samwalton9-WMF moved T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked from Up next to Kanban on the Moderator-Tools-Team board.

Tue, Aug 20, 4:24 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Scardenasmolinar moved T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked from To be estimated to Up next on the Moderator-Tools-Team board.

Tue, Aug 20, 3:32 PM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Scardenasmolinar moved T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked from Inbox to To be estimated on the Moderator-Tools-Team board.

Tue, Aug 20, 5:14 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Scardenasmolinar added a project to T357787: Inline thanks in recent changes doesn't work when live changes are enabled or 'view new changes' is clicked: Moderator-Tools-Team.

Tue, Aug 20, 5:14 AM · Patch-For-Review, Moderator-Tools-Team (Kanban), Growth-Team, MediaWiki-Recent-changes, Thanks

Mon, Aug 5

matej_suchanek changed the status of T235873: Add variables in Abusefilter to detect/block thanks from Stalled to In Progress.

Mon, Aug 5, 5:13 PM · Patch-For-Review, Trust and Safety Product Team, Growth-Team-Filtering, User-DannyS712, AbuseFilter, Growth-Team, Thanks

Aug 2 2024

Pppery removed a project from T364620: Show users if they were thanked when viewing a revision: MediaWiki-Special-pages.

Aug 2 2024, 4:24 AM · Growth-Team, Growth-Positive-Reinforcement, Thanks, MediaWiki-Page-history

Jul 24 2024

gerritbot added a project to T235873: Add variables in Abusefilter to detect/block thanks: Patch-For-Review.

Jul 24 2024, 6:38 PM · Patch-For-Review, Trust and Safety Product Team, Growth-Team-Filtering, User-DannyS712, AbuseFilter, Growth-Team, Thanks

gerritbot added a comment to T235873: Add variables in Abusefilter to detect/block thanks.

Change #1056582 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/extensions/Thanks@master] [POC] Process thanks by Abuse Filter

https://gerrit.wikimedia.org/r/1056582

Jul 24 2024, 6:38 PM · Patch-For-Review, Trust and Safety Product Team, Growth-Team-Filtering, User-DannyS712, AbuseFilter, Growth-Team, Thanks

Jul 22 2024

Maintenance_bot removed a project from T354875: build: Update SVGO to latest v3.2.0 in Wikimedia deployed repos: Patch-For-Review.

Jul 22 2024, 9:33 PM · MediaWiki-General, GrowthExperiments, Notifications, NearbyPages, TimedMediaHandler, VisualEditor, Timeless, UniversalLanguageSelector, MediaWiki-extensions-Translate, Thanks, MediaViewer, MediaWiki-extensions-CentralNotice, ChessBrowser, Maps (Kartographer), MediaWiki-extensions-GuidedTour, Desktop Improvements (Vector 2022), MinervaNeue, Two-Column-Edit-Conflict-Merge, Revision-Slider, Growth-Team, Page-Previews, MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), Wikimedia-Performance-recommendation, SVG

gerritbot added a comment to T354875: build: Update SVGO to latest v3.2.0 in Wikimedia deployed repos.

Change #1052668 merged by jenkins-bot:

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

Jul 22 2024, 8:58 PM · MediaWiki-General, GrowthExperiments, Notifications, NearbyPages, TimedMediaHandler, VisualEditor, Timeless, UniversalLanguageSelector, MediaWiki-extensions-Translate, Thanks, MediaViewer, MediaWiki-extensions-CentralNotice, ChessBrowser, Maps (Kartographer), MediaWiki-extensions-GuidedTour, Desktop Improvements (Vector 2022), MinervaNeue, Two-Column-Edit-Conflict-Merge, Revision-Slider, Growth-Team, Page-Previews, MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), Wikimedia-Performance-recommendation, SVG

Jul 14 2024

matej_suchanek added a comment to T235873: Add variables in Abusefilter to detect/block thanks.

This has recently again become an attack vector for abuse, so I'm reviving this task.

Jul 14 2024, 4:36 PM · Patch-For-Review, Trust and Safety Product Team, Growth-Team-Filtering, User-DannyS712, AbuseFilter, Growth-Team, Thanks

Jul 8 2024

gerritbot added a project to T354875: build: Update SVGO to latest v3.2.0 in Wikimedia deployed repos: Patch-For-Review.

Jul 8 2024, 8:31 AM · MediaWiki-General, GrowthExperiments, Notifications, NearbyPages, TimedMediaHandler, VisualEditor, Timeless, UniversalLanguageSelector, MediaWiki-extensions-Translate, Thanks, MediaViewer, MediaWiki-extensions-CentralNotice, ChessBrowser, Maps (Kartographer), MediaWiki-extensions-GuidedTour, Desktop Improvements (Vector 2022), MinervaNeue, Two-Column-Edit-Conflict-Merge, Revision-Slider, Growth-Team, Page-Previews, MW-1.42-notes (1.42.0-wmf.15; 2024-01-23), Wikimedia-Performance-recommendation, SVG

gerritbot added a comment to T354875: build: Update SVGO to latest v3.2.0 in Wikimedia deployed repos.

Change #1052668 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/CentralNotice@wmf_deploy] Merge branch 'master' into wmf_deploy

https://gerrit.wikimedia.org/r/1052668

Jun 12 2024

Pppery removed a project from T353062: Core diff on mobile buggy codex thank button: Patch-For-Review.

Jun 12 2024, 3:35 AM · MediaWiki-Page-diffs, MW-1.42-notes (1.42.0-wmf.14; 2024-01-16), Growth-Team, Thanks, MediaWiki-User-Interface

May 28 2024

Jdlrobson moved T359520: Thank button sometimes not working on Vector 2022 from Tracking (Waiting on other teams) to Tracking on the Desktop Improvements (Vector 2022) board.

May 28 2024, 8:57 PM · Desktop Improvements (Vector 2022) (Tracking), Growth-Team, Thanks

matmarex closed T249893: Add "Thanks" to talk page comments as Resolved.

Thanking can be tested on the beta cluster: https://en.wikipedia.beta.wmflabs.org/wiki/Talk:Main_Page?dtenable=1 but it won't be deployed to any production wikis yet. I filed a separate task for the deployment(s): T366095.

May 28 2024, 5:11 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), DiscussionTools, Growth-Team, Editing-team (Tracking), Thanks

matmarex added a parent task for T249893: Add "Thanks" to talk page comments: T366095: Deploy comment thanking to all wikis.

May 28 2024, 5:10 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), DiscussionTools, Growth-Team, Editing-team (Tracking), Thanks

ReleaseTaggerBot added a project to T249893: Add "Thanks" to talk page comments: MW-1.43-notes (1.43.0-wmf.8; 2024-06-04).

May 28 2024, 5:00 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), DiscussionTools, Growth-Team, Editing-team (Tracking), Thanks

gerritbot added a comment to T249893: Add "Thanks" to talk page comments.

Change #752325 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Comment thanking

https://gerrit.wikimedia.org/r/752325

May 28 2024, 4:12 PM · MW-1.43-notes (1.43.0-wmf.8; 2024-06-04), DiscussionTools, Growth-Team, Editing-team (Tracking), Thanks