Fix contact saved handle format #740
Conversation
|
Hey @laktyushin can you please help reviewing this pull request? |
| @@ -1072,7 +1072,8 @@ public func deviceContactInfoController(context: AccountContext, updatedPresenta | |||
| if let editingName = state.editingState?.editingName, case let .personName(firstName, lastName, _) = editingName, (!firstName.isEmpty || !lastName.isEmpty) { | |||
| var urls = filteredData.urls | |||
| if let createForPeer = createForPeer { | |||
| let appProfile = DeviceContactUrlData(appProfile: createForPeer.id) | |||
| let addressName: String = createForPeer.addressName ?? "" | |||
| let appProfile = DeviceContactUrlData(addressName: addressName) | |||
There was a problem hiding this comment.
It looks like you're using username instead of a raw numeric user ID, so the contact link may become invalid later as usernames may change, whereas user ID stays the same, so I would recommend using it instead.
There was a problem hiding this comment.
Up: I did some research and it seems like other clients (desktop, web) have no support for deep links right now so maybe it is fine to stick with usernames.
There was a problem hiding this comment.
Yes, username is working fine currently. So this pr should be good to go then?
There was a problem hiding this comment.
Well, this code was using deep links before, so maybe there was a reason for it. Anyways now it seems ok to me so let's wait for the others to decide (as I'm not a contributor).
|
|
Resolves: #685
Contact saved with peer id instead of handlename as https://t.me/@idId(rawValue:%xxx
After change:
